Skip to content

Commit a6f255e

Browse files
committed
Address Claude review feedback
- Describe the fingerprint hash accurately. The second lane uses a MurmurHash3 mixing constant, not the FNV prime, so calling both lanes FNV-1a was wrong. Comment only, no behavior change.
1 parent 6a564b1 commit a6f255e

1 file changed

Lines changed: 3 additions & 1 deletion

File tree

packages/core/src/credentials.ts

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -88,7 +88,9 @@ interface RedactionAccumulator {
8888
}
8989

9090
/**
91-
* Hash a credential value to a short, stable token (two FNV-1a lanes, 64 bits).
91+
* Hash a credential value to a short, stable 64-bit token: two independent
92+
* FNV-1a-style lanes, the first with the canonical FNV prime and the second
93+
* with a MurmurHash3 mixing constant so the lanes do not move together.
9294
*
9395
* The digest never leaves memory and is only ever compared for equality, so it
9496
* needs to be stable and cheap rather than cryptographic. Hashing rather than

0 commit comments

Comments
 (0)