Commit d8b06e9
authored
chore(deps): bump dompurify to 3.4.13; re-verify the image-size allowlist (#1769)
* chore(deps): bump dompurify to 3.4.13 for GHSA-55q2-fjhq-7xh7
DOMPurify <=3.4.12 leaves a detached subtree executable after IN_PLACE
hook removal, which allows XSS. 3.4.13 is the patched release.
dompurify is a direct dependency of geolibre-desktop at ^3.4.12, and the
three transitive consumers (@cesium/engine, @geoman-io/maplibre-geoman-free,
maplibre-gl-geoagent) all declare ranges that accept 3.4.13, so this is an
in-range `npm update` of the single deduped copy -- lockfile only, no
package.json change and no breaking upgrade.
This clears the only actionable advisory in `npm audit`. The remaining 16
high findings are all the image-size DoS pair (GHSA-w3rx-r6r6-pgpr,
GHSA-5p2g-fcmc-qvqq), which are already allowlisted in
scripts/audit-check.mjs; both halves of that rationale still hold --
image-size@2.0.2 is still the latest publish and the advisory covers
<=2.0.2, and it reaches us only through texture-compressor, which
@loaders.gl/textures shells out to via npx from a Node-only encoder
GeoLibre never calls.
* docs(audit): record the re-verified image-size allowlist rationale
Both image-size advisories were re-checked against the GitHub advisory
API, which reports first_patched_version: null for each — there is no
version to upgrade to, and 2.0.2 remains the newest release ever
published. Upgrading higher in the chain does not help either: the
latest @loaders.gl/textures (4.4.4) still depends on
texture-compressor@^1.0.2, which pins image-size@^0.7.4.
Unreachability was re-confirmed by grepping the production build, which
contains no reference to image-size or texture-compressor — consistent
with @loaders.gl/textures reaching the encoder by spawning it as a child
process (`command: 'npx'`) rather than importing it.
Also notes why the raw `npm audit` count is alarming and misleading: it
inflates these two advisories into ~16 high findings by counting them
once per package in the dependency chain, when the tree only ever holds
a single copy of image-size.
No behavior change — comments only.1 parent ef1cd24 commit d8b06e9
2 files changed
Lines changed: 16 additions & 6 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
19 | 19 | | |
20 | 20 | | |
21 | 21 | | |
22 | | - | |
| 22 | + | |
| 23 | + | |
| 24 | + | |
| 25 | + | |
23 | 26 | | |
24 | 27 | | |
25 | 28 | | |
26 | | - | |
| 29 | + | |
| 30 | + | |
| 31 | + | |
27 | 32 | | |
28 | 33 | | |
29 | 34 | | |
30 | 35 | | |
31 | 36 | | |
32 | | - | |
| 37 | + | |
| 38 | + | |
| 39 | + | |
| 40 | + | |
| 41 | + | |
| 42 | + | |
33 | 43 | | |
34 | 44 | | |
35 | 45 | | |
| |||
0 commit comments