fix(sidecar): stop leaking raw vector and SQL errors to clients (#1632)

* fix(sidecar): stop leaking raw vector and SQL errors to clients

* fix: rename test secret vars to sensitive_path to avoid Ruff S105

Replace the variable name 'secret' with 'sensitive_path' in test_sql.py
and test_vector.py to suppress Ruff S105 hardcoded-password-assigned
lint warnings.

* fix: use typed _boom helpers and assert exact error detail strings

Replace lambdas/untyped helpers with _boom(*_args: object, **_kwargs: object) -> NoReturn
in leak tests. Assert the exact generic detail string for each endpoint
instead of a case-insensitive substring match.

Author: Ayush7614

backend/geolibre_server/geolibre_server/app/sql.py

@@ -85,4 +85,7 @@ def sql_run(request: SqlRunRequest) -> dict[str, Any]:
         raise HTTPException(status_code=400, detail=str(exc)) from exc
     except Exception as exc:  # noqa: BLE001 - surface a stable error to the client
         logger.exception("Sedona SQL failed")
-        raise HTTPException(status_code=400, detail=f"Spatial SQL failed: {exc}") from exc
+        raise HTTPException(
+            status_code=400,
+            detail="Spatial SQL failed due to an internal error.",
+        ) from exc

backend/geolibre_server/geolibre_server/app/vector.py

@@ -106,7 +106,10 @@ def vector_run(request: VectorToolRequest):
         raise HTTPException(status_code=400, detail=str(exc)) from exc
     except Exception as exc:  # noqa: BLE001 - surface a stable error to the client
         logger.exception("Vector tool %s failed", request.tool_id)
-        raise HTTPException(status_code=400, detail=f"Vector tool failed: {exc}") from exc
+        raise HTTPException(
+            status_code=400,
+            detail="Vector tool failed due to an internal error.",
+        ) from exc
 
     return {"geojson": geojson, "messages": messages}
 
@@ -298,7 +301,10 @@ def vector_write(request: WriteVectorRequest):
         raise
     except Exception as exc:  # noqa: BLE001 - surface a stable error to the client
         logger.exception("Write-back to %s failed", target)
-        raise HTTPException(status_code=400, detail=f"Write-back failed: {exc}") from exc
+        raise HTTPException(
+            status_code=400,
+            detail="Write-back failed due to an internal error.",
+        ) from exc
 
     return {
         "path": str(target),

backend/geolibre_server/tests/test_sql.py

@@ -1,3 +1,5 @@
+from typing import NoReturn
+
 import pytest
 from fastapi import HTTPException
 
@@ -213,3 +215,19 @@ def close(self):
 
     with pytest.raises(SqlTimeout, match="timed out"):
         sedona_ops.run_sql("SELECT 1")
+
+
+def test_run_does_not_leak_exception_detail(monkeypatch: pytest.MonkeyPatch) -> None:
+    """Broad exceptions must not surface internal paths or secrets in the detail."""
+    sensitive_path = "/var/data/credentials.json"
+    monkeypatch.setattr(sedona_ops, "sedonadb_import_error", lambda: None)
+
+    def _boom(*_args: object, **_kwargs: object) -> NoReturn:
+        raise RuntimeError(f"Failed to read {sensitive_path}")  # noqa: TRY003
+
+    monkeypatch.setattr(sedona_ops, "run_sql", _boom)
+    with pytest.raises(HTTPException) as exc:
+        sql_run(SqlRunRequest(sql="SELECT 1"))
+    assert exc.value.status_code == 400
+    assert sensitive_path not in str(exc.value.detail)
+    assert exc.value.detail == "Spatial SQL failed due to an internal error."

backend/geolibre_server/tests/test_vector.py

@@ -1,3 +1,5 @@
+from typing import NoReturn
+
 import pytest
 from fastapi import HTTPException
 
@@ -349,6 +351,47 @@ def test_write_geopackage_preserves_source_crs(tmp_path) -> None:
     assert reread.crs.to_epsg() == 3857
 
 
+@requires_geopandas
+def test_run_does_not_leak_exception_detail(monkeypatch: pytest.MonkeyPatch) -> None:
+    """Broad exceptions must not surface internal paths or secrets in the detail."""
+    sensitive_path = "/var/secret/key.pem"
+    monkeypatch.setattr(vector_ops, "geopandas_import_error", lambda: None)
+
+    def _boom(*_args: object, **_kwargs: object) -> NoReturn:
+        raise RuntimeError(f"Cannot read {sensitive_path}")  # noqa: TRY003
+
+    monkeypatch.setattr(vector_ops, "run_vector_tool", _boom)
+    with pytest.raises(HTTPException) as exc:
+        vector_run(VectorToolRequest(tool_id="buffer", geojson=SQUARE))
+    assert exc.value.status_code == 400
+    assert sensitive_path not in str(exc.value.detail)
+    assert exc.value.detail == "Vector tool failed due to an internal error."
+
+
+@requires_geopandas
+def test_write_does_not_leak_exception_detail(tmp_path, monkeypatch: pytest.MonkeyPatch) -> None:
+    """Write-back broad exceptions must not surface internal detail."""
+    import geopandas as gpd
+
+    from geolibre_server.app import vector as vector_mod
+
+    src = tmp_path / "layer.geojson"
+    gpd.GeoDataFrame.from_features(_edited("a")["features"], crs="EPSG:4326").to_file(
+        src, driver="GeoJSON"
+    )
+    sensitive_path = "/etc/shadow"
+
+    def _boom(*_args: object, **_kwargs: object) -> NoReturn:
+        raise RuntimeError(f"leaked {sensitive_path}")  # noqa: TRY003
+
+    monkeypatch.setattr(vector_mod, "_write_geojson", _boom)
+    with pytest.raises(HTTPException) as exc:
+        vector_write(WriteVectorRequest(path=str(src), geojson=_edited("b")))
+    assert exc.value.status_code == 400
+    assert sensitive_path not in str(exc.value.detail)
+    assert exc.value.detail == "Write-back failed due to an internal error."
+
+
 @requires_geopandas
 def test_write_respects_conversion_allowlist(tmp_path, monkeypatch: pytest.MonkeyPatch) -> None:
     import geopandas as gpd