fix(backend): validate aspatial geopackage layer writes & add test coverage

Author: RohithPariki

backend/geolibre_server/geolibre_server/app/vector.py

@@ -229,6 +229,11 @@ def _write_geopackage(target: Path, geojson: dict, layer: Optional[str]) -> tupl
                 status_code=404,
                 detail=f"Layer '{layer}' not found in {target.name}",
             )
+        if layer not in spatial:
+            raise HTTPException(
+                status_code=400,
+                detail=f"Layer '{layer}' is an aspatial table and cannot be written",
+            )
         target_layer = layer
     elif spatial:
         # Match the reader's "first feature layer" default (gpkg-reader.ts

backend/geolibre_server/tests/test_vector.py

@@ -315,6 +315,29 @@ def test_write_geopackage_rejects_unknown_layer(tmp_path) -> None:
     assert exc.value.status_code == 404
 
 
+@requires_geopandas
+def test_write_geopackage_rejects_aspatial_layer(tmp_path, monkeypatch) -> None:
+    import geopandas as gpd
+    import pandas as pd
+
+    src = tmp_path / "layer.gpkg"
+    gpd.GeoDataFrame.from_features(_edited("a")["features"], crs="EPSG:4326").to_file(
+        src, layer="places", driver="GPKG"
+    )
+
+    def mock_list_layers(path):
+        return pd.DataFrame({
+            "name": ["places", "aspatial_data"],
+            "geometry_type": ["Polygon", None]
+        })
+    monkeypatch.setattr(gpd, "list_layers", mock_list_layers)
+
+    with pytest.raises(HTTPException) as exc:
+        vector_write(WriteVectorRequest(path=str(src), geojson=_edited("b"), layer="aspatial_data"))
+    assert exc.value.status_code == 400
+    assert "aspatial table" in exc.value.detail
+
+
 @requires_geopandas
 def test_write_geopackage_defaults_to_first_feature_layer(tmp_path) -> None:
     # With no layer specified, write-back targets the first feature layer, the

backend/geolibre_server/tests/test_vector_ops.py

@@ -1196,6 +1196,39 @@ def test_fix_geometries_no_op_on_valid_layer() -> None:
     assert any("already valid" in m for m in messages)
 
 
+@requires_geopandas
+def test_fix_geometries_leaves_unfixable_unchanged(monkeypatch) -> None:
+    # A degenerate polygon (e.g., <3 distinct points) that make_valid cannot repair
+    # into a valid polygonal area will either raise or return empty. The tool should
+    # leave the original unchanged and increment the unfixable count.
+    import shapely.validation
+    
+    def mock_make_valid(geom):
+        raise ValueError("Simulated unfixable geometry")
+        
+    monkeypatch.setattr(shapely.validation, "make_valid", mock_make_valid)
+
+    degenerate = {
+        "type": "FeatureCollection",
+        "features": [
+            {
+                "type": "Feature",
+                "properties": {"name": "degenerate"},
+                "geometry": {
+                    "type": "Polygon",
+                    "coordinates": [[[0, 0], [1, 1], [0, 0]]],
+                },
+            }
+        ],
+    }
+    geojson, messages = run_vector_tool("fix-geometries", degenerate)
+    assert len(geojson["features"]) == 1
+    # GeoPandas pads the LinearRing to 4 coordinates when loading/dumping
+    coords = geojson["features"][0]["geometry"]["coordinates"]
+    assert coords == [[[0.0, 0.0], [1.0, 1.0], [0.0, 0.0], [0.0, 0.0]]]
+    assert any("1 could not be repaired" in m for m in messages)
+
+
 @requires_geopandas
 def test_validity_anchor_parses_scientific_notation() -> None:
     anchor = vector_ops._validity_anchor("Self-intersection[1.5e-10 -2.3e-05]", None)