Commit e8bef1b
authored
fix(menu): disambiguate the Whitebox catalog's "GeoLibre" subcategory (#1913)
* fix(menu): disambiguate the Whitebox catalog's "GeoLibre" subcategory
The Processing menu had two unrelated things named "GeoLibre" in one tree:
the Whitebox catalog's provenance subcategory (Processing -> Conversion ->
GeoLibre) and the app's own tools submenu (Processing -> GeoLibre). Nothing in
either label told them apart, and the nine catalog categories render as bare
siblings of the GeoLibre submenu, so the two paths read as mirror images.
Two changes, neither adding depth:
- Rename the generator's GEOLIBRE_SUBCATEGORY to "GeoLibre (WASM)". The label
is a generator constant, not catalog data, and nothing keys off the literal
(the subcategory sort ranks against the constant), so this is one line plus a
regenerate. "(WASM)" is already the app's user-facing shorthand for the
in-browser runtime ("Run locally (WASM)"), so it reads as a runtime note
rather than a second product.
- Add a "Whitebox" section label above the catalog categories, and a separator
between that block and the GeoLibre submenu, so the two sections read as
separate owners. The dialog-opening item now uses the existing, already
translated "Whitebox toolbox" string so it says what clicking it does. A
label rather than a parent submenu: the grouping is worth one muted line, not
an extra hover on the way to every tool.
Refs #1904
* Address Claude review feedback
- Reflow the wasmOnly comment in gen-whitebox-menu-catalog.mjs; the
GEOLIBRE_SUBCATEGORY rename left it wrapped across three lines mid-clause.
* fix(menu): drop the Whitebox section label, title-case "Whitebox Toolbox"
The toolbox item alone heads the catalog categories; the extra muted label
above it was redundant with it. The separator before the GeoLibre submenu
stays, so the two sections still read as separate owners.
"Whitebox Toolbox" matches the title case of the sibling menu items (SQL
Workspace, Python Console, Jupyter Notebook). Retitling the shared
processing.whitebox.toolbox string rather than adding a menu-only key keeps
the item translated in all 19 locales; it also titles the toolbox dialog, so
that heading picks up the same casing in English.
* fix(menu): name the Processing GeoLibre submenu "GeoLibre Toolbox"
The submenu holding the app's own dialogs was labelled with the bare
product name, so it read as the product rather than as one of the two
toolboxes the Processing menu offers. Renaming it pairs it with its
"Whitebox Toolbox" sibling across the new separator and finishes the
disambiguation GeoLibre#1904 asks for.
"Toolbox" is a translatable word, so the string is translated in all 19
locales, each following that catalog's own wording for the existing
"Whitebox Toolbox" string.
* fix(i18n): repair the Vietnamese Processing menu strings
The Vietnamese catalog was badly wrong across the menu this PR renames.
Three classes of defect, 51 strings:
- **Value belongs to a different key.** `toolbar.command.pythonConsole`
read "Cài đặt" (Settings), `toolbar.rasterTool.zonal` read "Không thể
chạy công cụ raster." (an error message), `toolbar.item.projection`
read "địa hình" (Terrain), `toolbar.conversion.rasterToPmtiles` read a
whole unrelated error sentence, and `processing.whitebox.whiteboxTools`
read "Đầu ra sẽ xuất hiện ở đây." (Output will appear here.).
- **Product name translated as a common noun.** Whitebox became "hộp
trắng" (a white box), Earth Engine "Động cơ trái đất" (an earth motor),
Planetary Computer "Máy tính hành tinh", Jupyter Notebook "Máy tính
xách tay Jupyter" (a Jupyter laptop), and sidecar "xe sidecar" (a
motorcycle sidecar) in 11 places, though every other string in the
catalog already uses the bare loanword "sidecar".
- **Wrong sense of an ambiguous English word.** Moran's I came out as
"Tôi của Global Moran" / "Moran địa phương của tôi", reading the
statistic's "I" as the English pronoun. Clip was "Đoạn phim" (a film
clip), Union "Liên minh" (a political alliance), Intersection "Giao lộ"
(a road junction), Explode "nổ tung" (to blow up), Aspect "Diện mạo"
(someone's looks), Join "Tham gia" (to attend), Georeferencing "Hội
thảo địa lý" (a geography seminar).
Corrections follow the terminology the catalog already uses correctly
elsewhere, so the menu agrees with the dialogs it opens: "Bao lồi"
(convexHullLayerName), "Trọng tâm" (layerCentroids), "Bóng đồi"
(sampleImageServiceLabel), "Bảng điều khiển Python" (pythonConsole.title),
"Mã hóa địa lý" (settings.section.geocoding), "nối thuộc tính"
(delimitedText.tableHint), "Giao nhau" (selection.predicateIntersects).
* Address review feedback
- ui-profile.ts: point the `processing.whitebox` visibility toggle at
`processing.whitebox.toolbox`, the same key the Processing menu item now
uses. Both read "Whitebox" before this PR; leaving the toggle behind
meant Settings -> Interface Settings listed "Whitebox" for the row that
hides "Whitebox Toolbox". Verified in the running dialog, light and
dark. Also updated the stale comment above it, which still described the
submenu as "GeoLibre". (Claude review)
- vi.json: align the conversion labels on the terminology the catalog
already uses. It spells the data type "vectơ" 59 times against 39
"Vector", and `Vectơ sang Vectơ` sat directly above `Vector sang
GeoParquet` in the same submenu; `rasterToCog` used "tới" where its
neighbours use "sang". (CodeRabbit)
- vi.json: `rasterTool.inputPoints` held an error message ("Không thể
chạy công cụ raster.") instead of an input label, `engineClient` said
"Khách hàng" (a paying customer) and `engineSidecar` "Xe bên" (a side
vehicle). (CodeRabbit)
- vi.json: `conversion.vectorToVectorInputLabel` held "Liên minh"
(Union), the same mismatched-value class, found while verifying the
above; and two strings spelled WebAssembly "WebAssugging".
Left alone: `rasterTool.engine` / `vectorTools.engine` = "Động cơ", which
reads as a physical motor. CodeRabbit excluded it and there is no obvious
better Vietnamese term for a compute-engine selector, so it wants a
native speaker rather than another guess.1 parent cbdd941 commit e8bef1b
23 files changed
Lines changed: 148 additions & 125 deletions
Lines changed: 17 additions & 5 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
140 | 140 | | |
141 | 141 | | |
142 | 142 | | |
| 143 | + | |
| 144 | + | |
| 145 | + | |
| 146 | + | |
| 147 | + | |
| 148 | + | |
| 149 | + | |
143 | 150 | | |
144 | 151 | | |
145 | | - | |
| 152 | + | |
146 | 153 | | |
147 | 154 | | |
148 | 155 | | |
| |||
178 | 185 | | |
179 | 186 | | |
180 | 187 | | |
| 188 | + | |
| 189 | + | |
| 190 | + | |
181 | 191 | | |
182 | 192 | | |
183 | | - | |
184 | | - | |
185 | | - | |
186 | | - | |
| 193 | + | |
| 194 | + | |
| 195 | + | |
| 196 | + | |
| 197 | + | |
| 198 | + | |
187 | 199 | | |
188 | 200 | | |
189 | 201 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
2730 | 2730 | | |
2731 | 2731 | | |
2732 | 2732 | | |
2733 | | - | |
| 2733 | + | |
2734 | 2734 | | |
2735 | 2735 | | |
2736 | 2736 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
2551 | 2551 | | |
2552 | 2552 | | |
2553 | 2553 | | |
2554 | | - | |
| 2554 | + | |
2555 | 2555 | | |
2556 | 2556 | | |
2557 | 2557 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
2561 | 2561 | | |
2562 | 2562 | | |
2563 | 2563 | | |
2564 | | - | |
| 2564 | + | |
2565 | 2565 | | |
2566 | 2566 | | |
2567 | 2567 | | |
| |||
4073 | 4073 | | |
4074 | 4074 | | |
4075 | 4075 | | |
4076 | | - | |
| 4076 | + | |
4077 | 4077 | | |
4078 | 4078 | | |
4079 | 4079 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
2551 | 2551 | | |
2552 | 2552 | | |
2553 | 2553 | | |
2554 | | - | |
| 2554 | + | |
2555 | 2555 | | |
2556 | 2556 | | |
2557 | 2557 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
2551 | 2551 | | |
2552 | 2552 | | |
2553 | 2553 | | |
2554 | | - | |
| 2554 | + | |
2555 | 2555 | | |
2556 | 2556 | | |
2557 | 2557 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
2551 | 2551 | | |
2552 | 2552 | | |
2553 | 2553 | | |
2554 | | - | |
| 2554 | + | |
2555 | 2555 | | |
2556 | 2556 | | |
2557 | 2557 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
2551 | 2551 | | |
2552 | 2552 | | |
2553 | 2553 | | |
2554 | | - | |
| 2554 | + | |
2555 | 2555 | | |
2556 | 2556 | | |
2557 | 2557 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
2506 | 2506 | | |
2507 | 2507 | | |
2508 | 2508 | | |
2509 | | - | |
| 2509 | + | |
2510 | 2510 | | |
2511 | 2511 | | |
2512 | 2512 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
2551 | 2551 | | |
2552 | 2552 | | |
2553 | 2553 | | |
2554 | | - | |
| 2554 | + | |
2555 | 2555 | | |
2556 | 2556 | | |
2557 | 2557 | | |
| |||
0 commit comments