[java223] Compilation warnings + precision notice

Signed-off-by: Gwendal Roulleau <gwendal.roulleau@gmail.com>

Author: dalgwen

bundles/org.openhab.automation.java223/NOTICE

@@ -17,11 +17,14 @@ This bundle uses Apache Freemarker, with the 'Apache License 2.0'.
 In the 3rd party directory you will find a copy of the JavaScript Engine used by the Java223 binding, made by
 the user eobermuhlner (source available at https://github.com/eobermuhlner/java-scriptengine). This work is distributed
 under the MIT licence.
+Some modifications have been made to the original code, mainly null safe annotations, public accessor or several small
+methods. Each modification is marked with "JAVA223 modification".
 
-== External Java Compiler
+== External Java Compiler : Standalone JDK Compiler
 
 A fallback compiler is used if the Java 21 compiler is not available in the openHAB runtime.
 It is a GPL v2 work, from Christian Kohlschütter's Standalone JDK Compiler project (extracted from the JDK).
+(source available at https://github.com/kohlschutter/jdk.compiler.standalone)
 
 == Source Code
 

bundles/org.openhab.automation.java223/src/helper/java/helper/rules/RuleAnnotationParser.java

@@ -33,7 +33,6 @@
 import java.util.Map;
 import java.util.Set;
 import java.util.function.Supplier;
-import java.util.stream.Collectors;
 
 import org.eclipse.jdt.annotation.NonNullByDefault;
 import org.openhab.core.automation.Condition;

bundles/org.openhab.automation.java223/src/test/java/org/openhab/automation/java223/internal/rules/Java223RuleTest.java

@@ -119,7 +119,7 @@ public void fieldConstructorExecutesCallableField() throws Exception {
     @Test
     public void fieldConstructorExecutesCallableAndWrapsCheckedException() throws Exception {
         ScriptWithCallable script = new ScriptWithCallable(() -> {
-            throw new Exception("checked");
+            throw new Java223Exception("checked");
         });
         Field field = ScriptWithCallable.class.getDeclaredField("callable");
 
@@ -280,7 +280,7 @@ public void fieldConstructorExecutesCallableFieldWithDerivedClass() throws Excep
         Field field = ScriptWithRunnableDerived.class.getDeclaredField("runnable");
 
         Java223Rule rule = new Java223Rule(script, field);
-        Object result = rule.execute(emptyAction, new HashMap<>());
+        rule.execute(emptyAction, new HashMap<>());
 
         assertEquals(1, runnableDerived.getCount(), "runnable.run() result must be executed");
     }
@@ -406,7 +406,7 @@ public String methodWithAction(Action action) {
         }
 
         public String throwingMethod() {
-            throw new RuntimeException("kaboom");
+            throw new Java223Exception("kaboom");
         }
     }
 }

bundles/org.openhab.automation.java223/src/test/java/org/openhab/automation/java223/internal/strategy/jarloader/JarClassLoaderTest.java

@@ -42,8 +42,9 @@ public class JarClassLoaderTest {
     @Test
     public void testGetResourceAsStream() throws IOException {
         Path localTempDir = tempDir;
-        if ((localTempDir == null))
+        if ((localTempDir == null)) {
             throw new AssertionError("Temp directory is null. Should not happen");
+        }
         Path jarPath = localTempDir.resolve("test with space.jar");
         createJar(jarPath, "test with space.txt", "Hello World");