Address copilot review comments

Signed-off-by: Kai Kreuzer <kai@openhab.org>

Author: kaikreuzer

bundles/org.openhab.binding.matter/src/main/java/org/openhab/binding/matter/internal/controller/devices/converter/ContactStateConverter.java

@@ -13,7 +13,7 @@
 package org.openhab.binding.matter.internal.controller.devices.converter;
 
 import static org.openhab.binding.matter.internal.MatterBindingConstants.CHANNEL_CONTACT_STATEVALUE;
-import static org.openhab.binding.matter.internal.MatterBindingConstants.CHANNEL_ID_CONTACT_STATEVALUE;
+import static org.openhab.binding.matter.internal.MatterBindingConstants.CHANNEL_ID_BOOLEANSTATE_STATEVALUE;
 
 import java.util.Collections;
 import java.util.Map;
@@ -49,7 +49,7 @@ public ContactStateConverter(BooleanStateCluster cluster, MatterBaseThingHandler
     @Override
     public Map<Channel, @Nullable StateDescription> createChannels(ChannelGroupUID channelGroupUID) {
         Channel channel = ChannelBuilder
-                .create(new ChannelUID(channelGroupUID, CHANNEL_ID_CONTACT_STATEVALUE), CoreItemFactory.CONTACT)
+                .create(new ChannelUID(channelGroupUID, CHANNEL_ID_BOOLEANSTATE_STATEVALUE), CoreItemFactory.CONTACT)
                 .withType(CHANNEL_CONTACT_STATEVALUE).build();
         return Collections.singletonMap(channel, null);
     }
@@ -59,7 +59,7 @@ public void onEvent(AttributeChangedMessage message) {
         switch (message.path.attributeName) {
             case BooleanStateCluster.ATTRIBUTE_STATE_VALUE -> {
                 if (message.value instanceof Boolean booleanValue) {
-                    updateState(CHANNEL_ID_CONTACT_STATEVALUE,
+                    updateState(CHANNEL_ID_BOOLEANSTATE_STATEVALUE,
                             booleanValue ? OpenClosedType.CLOSED : OpenClosedType.OPEN);
                 }
             }
@@ -69,7 +69,7 @@ public void onEvent(AttributeChangedMessage message) {
 
     @Override
     public void initState() {
-        updateState(CHANNEL_ID_CONTACT_STATEVALUE,
+        updateState(CHANNEL_ID_BOOLEANSTATE_STATEVALUE,
                 initializingCluster.stateValue ? OpenClosedType.CLOSED : OpenClosedType.OPEN);
     }
 }

bundles/org.openhab.binding.matter/src/test/java/org/openhab/binding/matter/internal/controller/devices/converter/ContactStateConverterTest.java

@@ -59,7 +59,7 @@ void testCreateChannels() {
         Map<Channel, @Nullable StateDescription> channels = contactConverter.createChannels(thingUID);
         assertEquals(1, channels.size());
         Channel channel = channels.keySet().iterator().next();
-        assertEquals("matter:node:test:12345:1#contact-statevalue", channel.getUID().toString());
+        assertEquals("matter:node:test:12345:1#booleanstate-statevalue", channel.getUID().toString());
         assertEquals("Contact", channel.getAcceptedItemType());
     }
 
@@ -70,7 +70,7 @@ void testOnEventWithBooleanValueTrue() throws Exception {
         message.path.attributeName = "stateValue";
         message.value = true;
         contactConverter.onEvent(message);
-        verify(mockHandler, times(1)).updateState(eq(1), eq("contact-statevalue"), eq(OpenClosedType.CLOSED));
+        verify(mockHandler, times(1)).updateState(eq(1), eq("booleanstate-statevalue"), eq(OpenClosedType.CLOSED));
     }
 
     @Test
@@ -80,13 +80,13 @@ void testOnEventWithBooleanValueFalse() throws Exception {
         message.path.attributeName = "stateValue";
         message.value = false;
         contactConverter.onEvent(message);
-        verify(mockHandler, times(1)).updateState(eq(1), eq("contact-statevalue"), eq(OpenClosedType.OPEN));
+        verify(mockHandler, times(1)).updateState(eq(1), eq("booleanstate-statevalue"), eq(OpenClosedType.OPEN));
     }
 
     @Test
     void testInitState() throws Exception {
         mockCluster.stateValue = true;
         contactConverter.initState();
-        verify(mockHandler, times(1)).updateState(eq(1), eq("contact-statevalue"), eq(OpenClosedType.CLOSED));
+        verify(mockHandler, times(1)).updateState(eq(1), eq("booleanstate-statevalue"), eq(OpenClosedType.CLOSED));
     }
 }