[oppo] Set playback status channels to UNDEF when Thing is off or offline (#20488)

* Update play_mode when Thing is off or offline

Signed-off-by: Michael Lobstein <michael.lobstein@gmail.com>

Author: mlobstein

bundles/org.openhab.binding.oppo/README.md

@@ -99,7 +99,7 @@ The following channels are available:
 | time_display      | Number:Time | The playback time elapsed/remaining in seconds (ReadOnly)                                                                             |
 | current_title     | Number      | The current title or track number playing (ReadOnly)                                                                                  |
 | total_title       | Number      | The total number of titles or tracks on the disc (ReadOnly)                                                                           |
-| current_chapter   | Number      | The current chapter number (ReadOnly)                                                                                                  |
+| current_chapter   | Number      | The current chapter number (ReadOnly)                                                                                                 |
 | total_chapter     | Number      | The total number of chapters in the current title (ReadOnly)                                                                          |
 | repeat_mode       | String      | Sets the current repeat mode (00-06)                                                                                                  |
 | zoom_mode         | String      | Sets the current zoom mode (00-12)                                                                                                    |

bundles/org.openhab.binding.oppo/src/main/java/org/openhab/binding/oppo/internal/OppoBindingConstants.java

@@ -76,7 +76,6 @@ public class OppoBindingConstants {
     public static final String OFF = "OFF";
     public static final String ONE = "1";
     public static final String ZERO = "0";
-    public static final String UNDEF = "UNDEF";
     public static final String VERBOSE_2 = "2";
     public static final String VERBOSE_3 = "3";
     public static final String MUTE = "MUTE";

bundles/org.openhab.binding.oppo/src/main/java/org/openhab/binding/oppo/internal/handler/OppoHandler.java

@@ -262,6 +262,10 @@ public void handleCommand(ChannelUID channelUID, Command command) {
                             if (command == OnOffType.OFF) {
                                 isPowerOn = false;
                                 isInitialQuery = false;
+                                if (!BLANK.equals(currentPlayMode)) {
+                                    currentPlayMode = BLANK;
+                                    clearStatusChannels(true);
+                                }
                             }
                         }
                         break;
@@ -368,6 +372,11 @@ private synchronized boolean openConnection() {
      * Close the connection with the Oppo player
      */
     private synchronized void closeConnection() {
+        if (!BLANK.equals(currentPlayMode)) {
+            currentPlayMode = BLANK;
+            clearStatusChannels(true);
+        }
+
         if (connector.isConnected()) {
             connector.close();
             connector.removeEventListener(this);
@@ -434,7 +443,10 @@ public void onNewMessageEvent(OppoMessageEvent evt) {
                     case QPW:
                         updateChannelState(CHANNEL_POWER, updateData);
                         if (OFF.equals(updateData)) {
-                            currentPlayMode = BLANK;
+                            if (!BLANK.equals(currentPlayMode)) {
+                                currentPlayMode = BLANK;
+                                clearStatusChannels(true);
+                            }
                             isPowerOn = false;
                         } else {
                             isPowerOn = true;
@@ -443,7 +455,10 @@ public void onNewMessageEvent(OppoMessageEvent evt) {
                     case UPW:
                         updateChannelState(CHANNEL_POWER, ONE.equals(updateData) ? ON : OFF);
                         if (ZERO.equals(updateData)) {
-                            currentPlayMode = BLANK;
+                            if (!BLANK.equals(currentPlayMode)) {
+                                currentPlayMode = BLANK;
+                                clearStatusChannels(true);
+                            }
                             isPowerOn = false;
                             isInitialQuery = false;
                         } else {
@@ -493,13 +508,7 @@ public void onNewMessageEvent(OppoMessageEvent evt) {
                         if (NO_DISC.equals(currentPlayMode) || LOADING.equals(currentPlayMode)
                                 || OPEN.equals(currentPlayMode) || CLOSE.equals(currentPlayMode)
                                 || STOP.equals(currentPlayMode)) {
-                            updateChannelState(CHANNEL_CURRENT_TITLE, ZERO);
-                            updateChannelState(CHANNEL_TOTAL_TITLE, ZERO);
-                            updateChannelState(CHANNEL_CURRENT_CHAPTER, ZERO);
-                            updateChannelState(CHANNEL_TOTAL_CHAPTER, ZERO);
-                            updateChannelState(CHANNEL_TIME_DISPLAY, UNDEF);
-                            updateChannelState(CHANNEL_AUDIO_TYPE, UNDEF);
-                            updateChannelState(CHANNEL_SUBTITLE_TYPE, UNDEF);
+                            clearStatusChannels(false);
                         }
                         updateChannelState(CHANNEL_PLAY_MODE, currentPlayMode);
                         updateState(CHANNEL_CONTROL,
@@ -590,6 +599,22 @@ public void onNewMessageEvent(OppoMessageEvent evt) {
         }
     }
 
+    /**
+     * Clears the status channels
+     */
+    private void clearStatusChannels(boolean clearPlayMode) {
+        if (clearPlayMode) {
+            updateChannelState(CHANNEL_PLAY_MODE, null);
+        }
+        updateChannelState(CHANNEL_CURRENT_TITLE, null);
+        updateChannelState(CHANNEL_TOTAL_TITLE, null);
+        updateChannelState(CHANNEL_CURRENT_CHAPTER, null);
+        updateChannelState(CHANNEL_TOTAL_CHAPTER, null);
+        updateChannelState(CHANNEL_TIME_DISPLAY, null);
+        updateChannelState(CHANNEL_AUDIO_TYPE, null);
+        updateChannelState(CHANNEL_SUBTITLE_TYPE, null);
+    }
+
     /**
      * Schedule the reconnection job
      */
@@ -760,12 +785,12 @@ private void cancelPollingJob() {
      * @param channel the channel
      * @param value the value to be updated
      */
-    private void updateChannelState(String channel, String value) {
+    private void updateChannelState(String channel, @Nullable String value) {
         if (!isLinked(channel)) {
             return;
         }
 
-        if (UNDEF.equals(value)) {
+        if (value == null) {
             updateState(channel, UnDefType.UNDEF);
             return;
         }