Skip to content

Commit df33a97

Browse files
More review fixes
Signed-off-by: Scott Hanson <scooter_seh@yahoo.com>
1 parent 5e0f8d1 commit df33a97

7 files changed

Lines changed: 11 additions & 11 deletions

File tree

bundles/org.openhab.binding.pirateweather/src/main/java/org/openhab/binding/pirateweather/internal/connection/PirateWeatherConnection.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,7 @@
3333
import org.eclipse.jetty.client.api.ContentResponse;
3434
import org.openhab.binding.pirateweather.internal.config.PirateWeatherAPIConfiguration;
3535
import org.openhab.binding.pirateweather.internal.handler.PirateWeatherAPIHandler;
36-
import org.openhab.binding.pirateweather.internal.model.PirateWeatherJsonWeatherData;
36+
import org.openhab.binding.pirateweather.internal.dto.PirateWeatherJsonWeatherData;
3737
import org.openhab.core.cache.ExpiringCacheMap;
3838
import org.openhab.core.library.types.PointType;
3939
import org.slf4j.Logger;

bundles/org.openhab.binding.pirateweather/src/main/java/org/openhab/binding/pirateweather/internal/model/PirateWeatherCurrentlyData.java renamed to bundles/org.openhab.binding.pirateweather/src/main/java/org/openhab/binding/pirateweather/internal/dto/PirateWeatherCurrentlyData.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@
1010
*
1111
* SPDX-License-Identifier: EPL-2.0
1212
*/
13-
package org.openhab.binding.pirateweather.internal.model;
13+
package org.openhab.binding.pirateweather.internal.dto;
1414

1515
/**
1616
* The {@link PirateWeatherCurrentlyData} is the Java class used to map the JSON response to an Pirate Weather request.

bundles/org.openhab.binding.pirateweather/src/main/java/org/openhab/binding/pirateweather/internal/model/PirateWeatherDailyData.java renamed to bundles/org.openhab.binding.pirateweather/src/main/java/org/openhab/binding/pirateweather/internal/dto/PirateWeatherDailyData.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@
1010
*
1111
* SPDX-License-Identifier: EPL-2.0
1212
*/
13-
package org.openhab.binding.pirateweather.internal.model;
13+
package org.openhab.binding.pirateweather.internal.dto;
1414

1515
import java.util.List;
1616

bundles/org.openhab.binding.pirateweather/src/main/java/org/openhab/binding/pirateweather/internal/model/PirateWeatherHourlyData.java renamed to bundles/org.openhab.binding.pirateweather/src/main/java/org/openhab/binding/pirateweather/internal/dto/PirateWeatherHourlyData.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@
1010
*
1111
* SPDX-License-Identifier: EPL-2.0
1212
*/
13-
package org.openhab.binding.pirateweather.internal.model;
13+
package org.openhab.binding.pirateweather.internal.dto;
1414

1515
import java.util.List;
1616

bundles/org.openhab.binding.pirateweather/src/main/java/org/openhab/binding/pirateweather/internal/model/PirateWeatherJsonWeatherData.java renamed to bundles/org.openhab.binding.pirateweather/src/main/java/org/openhab/binding/pirateweather/internal/dto/PirateWeatherJsonWeatherData.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@
1010
*
1111
* SPDX-License-Identifier: EPL-2.0
1212
*/
13-
package org.openhab.binding.pirateweather.internal.model;
13+
package org.openhab.binding.pirateweather.internal.dto;
1414

1515
import java.util.List;
1616

bundles/org.openhab.binding.pirateweather/src/main/java/org/openhab/binding/pirateweather/internal/handler/PirateWeatherAPIHandler.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -126,7 +126,7 @@ public void dispose() {
126126
@Override
127127
public void handleCommand(ChannelUID channelUID, Command command) {
128128
if (command instanceof RefreshType) {
129-
scheduler.schedule(this::updateThings, INITIAL_DELAY_IN_SECONDS, TimeUnit.SECONDS);
129+
updateThings();
130130
} else {
131131
logger.debug("The Pirate Weather binding is a read-only binding and cannot handle command '{}'.", command);
132132
}

bundles/org.openhab.binding.pirateweather/src/main/java/org/openhab/binding/pirateweather/internal/handler/PirateWeatherWeatherAndForecastHandler.java

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -42,11 +42,11 @@
4242
import org.openhab.binding.pirateweather.internal.connection.PirateWeatherCommunicationException;
4343
import org.openhab.binding.pirateweather.internal.connection.PirateWeatherConfigurationException;
4444
import org.openhab.binding.pirateweather.internal.connection.PirateWeatherConnection;
45-
import org.openhab.binding.pirateweather.internal.model.PirateWeatherCurrentlyData;
46-
import org.openhab.binding.pirateweather.internal.model.PirateWeatherDailyData.DailyData;
47-
import org.openhab.binding.pirateweather.internal.model.PirateWeatherHourlyData.HourlyData;
48-
import org.openhab.binding.pirateweather.internal.model.PirateWeatherJsonWeatherData;
49-
import org.openhab.binding.pirateweather.internal.model.PirateWeatherJsonWeatherData.AlertsData;
45+
import org.openhab.binding.pirateweather.internal.dto.PirateWeatherCurrentlyData;
46+
import org.openhab.binding.pirateweather.internal.dto.PirateWeatherDailyData.DailyData;
47+
import org.openhab.binding.pirateweather.internal.dto.PirateWeatherHourlyData.HourlyData;
48+
import org.openhab.binding.pirateweather.internal.dto.PirateWeatherJsonWeatherData;
49+
import org.openhab.binding.pirateweather.internal.dto.PirateWeatherJsonWeatherData.AlertsData;
5050
import org.openhab.core.library.types.DateTimeType;
5151
import org.openhab.core.library.types.DecimalType;
5252
import org.openhab.core.library.types.PointType;

0 commit comments

Comments
 (0)