Prevent channel updates if an error was raised in API answer. (#21275)

Signed-off-by: clinique <gael@lhopital.org>

Author: clinique

bundles/org.openhab.binding.netatmo/src/main/java/org/openhab/binding/netatmo/internal/handler/CommonInterface.java

@@ -31,6 +31,7 @@
 import org.openhab.binding.netatmo.internal.config.NAThingConfiguration;
 import org.openhab.binding.netatmo.internal.handler.capability.Capability;
 import org.openhab.binding.netatmo.internal.handler.capability.CapabilityMap;
+import org.openhab.binding.netatmo.internal.handler.capability.ChannelHelperCapability;
 import org.openhab.binding.netatmo.internal.handler.capability.HomeCapability;
 import org.openhab.binding.netatmo.internal.handler.capability.ParentUpdateCapability;
 import org.openhab.binding.netatmo.internal.handler.capability.RefreshCapability;
@@ -177,22 +178,29 @@ default <T extends RestCapability<?>> Optional<T> getHomeCapability(Class<T> cla
     }
 
     default void setNewData(NAObject newData) {
-        if (newData instanceof NAThing thingData) {
-            if (getId().equals(thingData.getBridge())) {
-                getActiveChildren().stream().filter(child -> child.getId().equals(thingData.getId())).findFirst()
-                        .ifPresent(child -> child.setNewData(thingData));
-                return;
-            }
+        if (newData instanceof NAThing thingData && getId().equals(thingData.getBridge())) {
+            getActiveChildren().stream().filter(child -> child.getId().equals(thingData.getId())). //
+                    findFirst().ifPresent(child -> child.setNewData(thingData));
+            return;
         }
 
         String finalReason = null;
+        ChannelHelperCapability channelHelper = null;
         for (Capability cap : getCapabilities().values()) {
-            String statusReason = cap.setNewData(newData);
-            if (statusReason != null) {
-                finalReason = statusReason;
+            if (cap instanceof ChannelHelperCapability) {
+                channelHelper = (ChannelHelperCapability) cap;
+            } else {
+                if (cap.setNewData(newData) instanceof String statusReason) {
+                    finalReason = statusReason;
+                }
             }
         }
 
+        // Handle channel updates only if no error was raised
+        if (channelHelper != null && finalReason == null) {
+            channelHelper.setNewData(newData);
+        }
+
         if (newData.isIgnoredForThingUpdate()) {
             return;
         }

bundles/org.openhab.binding.netatmo/src/main/java/org/openhab/binding/netatmo/internal/handler/capability/DeviceCapability.java

@@ -19,7 +19,7 @@
 import org.openhab.binding.netatmo.internal.handler.CommonInterface;
 
 /**
- * The {@link DeviceCapability} takes care of handling properties for netatmo devices
+ * The {@link DeviceCapability} takes care of handling properties for Netatmo devices
  *
  * @author Gaël L'hopital - Initial contribution
  *