[roborock] Addressed issues reported by static analysis

Signed-off-by: Maciej Pham <reyhard@o2.pl>

Author: reyhard

bundles/org.openhab.binding.roborock/src/main/java/org/openhab/binding/roborock/internal/transport/LocalDirectTransport.java

@@ -321,7 +321,7 @@ private void invalidateSession(String reason, @Nullable Throwable cause) {
             if (cause != null) {
                 logger.debug("{} Cause: {}", reason, cause.getMessage());
             } else if (logger.isTraceEnabled()) {
-                logger.trace(reason);
+                logger.trace("{}", reason);
             }
 
             if (socket == null) {

bundles/org.openhab.binding.roborock/src/test/java/org/openhab/binding/roborock/internal/CloudRefreshPolicyTest.java

@@ -15,8 +15,10 @@
 import static org.junit.jupiter.api.Assertions.assertFalse;
 import static org.junit.jupiter.api.Assertions.assertTrue;
 
+import org.eclipse.jdt.annotation.NonNullByDefault;
 import org.junit.jupiter.api.Test;
 
+@NonNullByDefault({})
 class CloudRefreshPolicyTest {
 
     @Test

bundles/org.openhab.binding.roborock/src/test/java/org/openhab/binding/roborock/internal/MapUpdateDeduplicatorTest.java

@@ -15,8 +15,10 @@
 import static org.junit.jupiter.api.Assertions.assertFalse;
 import static org.junit.jupiter.api.Assertions.assertTrue;
 
+import org.eclipse.jdt.annotation.NonNullByDefault;
 import org.junit.jupiter.api.Test;
 
+@NonNullByDefault({})
 class MapUpdateDeduplicatorTest {
 
     @Test

bundles/org.openhab.binding.roborock/src/test/java/org/openhab/binding/roborock/internal/MqttInboundLivenessWatchdogTest.java

@@ -18,9 +18,11 @@
 import java.time.Duration;
 import java.time.Instant;
 
+import org.eclipse.jdt.annotation.NonNullByDefault;
 import org.junit.jupiter.api.Test;
 import org.openhab.binding.roborock.internal.MqttInboundLivenessWatchdog.Decision;
 
+@NonNullByDefault({})
 class MqttInboundLivenessWatchdogTest {
 
     @Test

bundles/org.openhab.binding.roborock/src/test/java/org/openhab/binding/roborock/internal/RoborockAccountHandlerRoutingTest.java

@@ -14,8 +14,10 @@
 
 import static org.junit.jupiter.api.Assertions.assertEquals;
 
+import org.eclipse.jdt.annotation.NonNullByDefault;
 import org.junit.jupiter.api.Test;
 
+@NonNullByDefault({})
 class RoborockAccountHandlerRoutingTest {
 
     @Test

bundles/org.openhab.binding.roborock/src/test/java/org/openhab/binding/roborock/internal/RoborockCommunicationModeTest.java

@@ -14,8 +14,10 @@
 
 import static org.junit.jupiter.api.Assertions.assertEquals;
 
+import org.eclipse.jdt.annotation.NonNullByDefault;
 import org.junit.jupiter.api.Test;
 
+@NonNullByDefault({})
 class RoborockCommunicationModeTest {
 
     @Test

bundles/org.openhab.binding.roborock/src/test/java/org/openhab/binding/roborock/internal/RoborockTransportRoutingTest.java

@@ -17,8 +17,10 @@
 import static org.openhab.binding.roborock.internal.RoborockBindingConstants.COMMAND_APP_START;
 import static org.openhab.binding.roborock.internal.RoborockBindingConstants.COMMAND_GET_MAP;
 
+import org.eclipse.jdt.annotation.NonNullByDefault;
 import org.junit.jupiter.api.Test;
 
+@NonNullByDefault({})
 class RoborockTransportRoutingTest {
 
     @Test

bundles/org.openhab.binding.roborock/src/test/java/org/openhab/binding/roborock/internal/RoborockVacuumConfigurationTest.java

@@ -16,8 +16,10 @@
 import static org.junit.jupiter.api.Assertions.assertFalse;
 import static org.junit.jupiter.api.Assertions.assertTrue;
 
+import org.eclipse.jdt.annotation.NonNullByDefault;
 import org.junit.jupiter.api.Test;
 
+@NonNullByDefault({})
 class RoborockVacuumConfigurationTest {
 
     @Test

bundles/org.openhab.binding.roborock/src/test/java/org/openhab/binding/roborock/internal/RoborockVacuumHandlerConsumableWriterTest.java

@@ -19,8 +19,10 @@
 import java.nio.file.Files;
 import java.nio.file.Path;
 
+import org.eclipse.jdt.annotation.NonNullByDefault;
 import org.junit.jupiter.api.Test;
 
+@NonNullByDefault({})
 class RoborockVacuumHandlerConsumableWriterTest {
 
     private static final Path HANDLER_PATH = Path

bundles/org.openhab.binding.roborock/src/test/java/org/openhab/binding/roborock/internal/RoborockVacuumHandlerPathResolutionTest.java

@@ -19,9 +19,11 @@
 import java.nio.file.Path;
 import java.nio.file.Paths;
 
+import org.eclipse.jdt.annotation.NonNullByDefault;
 import org.junit.jupiter.api.Test;
 import org.junit.jupiter.api.io.TempDir;
 
+@NonNullByDefault({})
 class RoborockVacuumHandlerPathResolutionTest {
 
     @Test