review comments

Signed-off-by: Holger Friedrich <mail@holger-friedrich.de>

Author: holgerfriedrich

.github/workflows/update-maven.yml

@@ -12,32 +12,35 @@ jobs:
       pull-requests: write
     runs-on: ubuntu-latest
     steps:
-      - uses: actions/checkout@v4
+      - uses: actions/checkout@v6
 
       - uses: actions/setup-java@v5
         with:
           java-version: '21'
           distribution: 'temurin'
 
       - name: Get latest Maven version
-        # This fetches latest Maven releas from maven.org - not the download page; it might be delayed a few days after releases.
-        # Note that the "gav" at the end of the URL ensures we use only generally available version. As of now, this is 3.x.
+        # This fetches latest Maven release from maven.org - not the download page; it might be delayed a few days after releases.
+        # Note that the "gav" at the end of the URL is necessary to retrieve more than one version. jq will filter out rc versions.
         id: maven
         run: |
-          LATEST=$(curl -s "https://search.maven.org/solrsearch/select?q=g:org.apache.maven+a:apache-maven&rows=1&wt=json&core=gav" \
+          LATEST=$(curl -s "https://search.maven.org/solrsearch/select?q=g:org.apache.maven+a:apache-maven&rows=20&wt=json&core=gav" \
             | jq -r '[.response.docs[].v | select(test("^3\\.\\d+\\.\\d+$"))] | first')
           echo "version=$LATEST" >> $GITHUB_OUTPUT
 
       - name: Update wrapper
         # Update Maven wrapper scripts AND maven-wrapper.properties.
         # Note that this removes the SHA from properties file.
-        run: ./mvnw wrapper:wrapper -Dmaven=${{ steps.maven.outputs.version }}
+        env:
+          VERSION: ${{ steps.maven.outputs.version }}
+        run: ./mvnw wrapper:wrapper -Dmaven="${VERSION}"
 
       - name: Patch SHA512 into wrapper properties
         # Add the SHA to properties file.
-        # We might need the -L for curl, as after a new release all old SHA files will move to .
+        # We might need the -L for curl, as after a new release all old SHA files will move to archive folder.
+        env:
+          VERSION: ${{ steps.maven.outputs.version }}
         run: |
-          VERSION=${{ steps.maven.outputs.version }}
           MAJOR=$(echo "$VERSION" | cut -d. -f1)
           SHA=$(curl -sL "https://downloads.apache.org/maven/maven-${MAJOR}/${VERSION}/binaries/apache-maven-${VERSION}-bin.zip.sha512")
           PROPS=".mvn/wrapper/maven-wrapper.properties"