Fix unstable audio console test

Use a one-shot test stream instead of a stream with an arbitrary five-second expiration. This prevents slow CI runners from expiring the stream before URLAudioStream connects to it.

Assert the captured stream type explicitly and close it after verification so failures are clearer and resources are released.

Fixes #3405

Signed-off-by: Wouter Born <github@maindrain.net> (github: wborn)

Author: wborn

bundles/org.openhab.core.audio/src/test/java/org/openhab/core/audio/internal/AudioConsoleTest.java

@@ -14,6 +14,7 @@
 
 import static org.hamcrest.CoreMatchers.*;
 import static org.hamcrest.MatcherAssert.assertThat;
+import static org.junit.jupiter.api.Assertions.assertInstanceOf;
 import static org.mockito.Mockito.mock;
 import static org.mockito.Mockito.when;
 
@@ -70,8 +71,6 @@ public void print(String s) {
         }
     };
 
-    private final int testTimeout = 5;
-
     @BeforeEach
     public void setUp() throws IOException {
         fileHandler = new BundledSoundFileHandler();
@@ -146,25 +145,29 @@ public void audioConsolePlaysStream() throws Exception {
         AudioStream audioStream = getByteArrayAudioStream(testByteArray, AudioFormat.CONTAINER_WAVE,
                 AudioFormat.CODEC_PCM_SIGNED);
 
-        String url = serveStream(audioStream, testTimeout);
+        String url = serveStream(audioStream);
 
         String[] args = { AudioConsoleCommandExtension.SUBCMD_STREAM, url };
         audioConsoleCommandExtension.execute(args, consoleMock);
 
-        assertThat("The streamed URL was not as expected", ((URLAudioStream) audioSink.audioStream).getURL(), is(url));
+        URLAudioStream urlAudioStream = assertInstanceOf(URLAudioStream.class, audioSink.audioStream);
+        assertThat("The streamed URL was not as expected", urlAudioStream.getURL(), is(url));
+        urlAudioStream.close();
     }
 
     @Test
     public void audioConsolePlaysStreamForASpecifiedSink() throws Exception {
         AudioStream audioStream = getByteArrayAudioStream(testByteArray, AudioFormat.CONTAINER_WAVE,
                 AudioFormat.CODEC_PCM_SIGNED);
 
-        String url = serveStream(audioStream, testTimeout);
+        String url = serveStream(audioStream);
 
         String[] args = { AudioConsoleCommandExtension.SUBCMD_STREAM, audioSink.getId(), url };
         audioConsoleCommandExtension.execute(args, consoleMock);
 
-        assertThat("The streamed URL was not as expected", ((URLAudioStream) audioSink.audioStream).getURL(), is(url));
+        URLAudioStream urlAudioStream = assertInstanceOf(URLAudioStream.class, audioSink.audioStream);
+        assertThat("The streamed URL was not as expected", urlAudioStream.getURL(), is(url));
+        urlAudioStream.close();
     }
 
     @Test