Skip to content

Commit 61846cd

Browse files
committed
fix spotless and copilot suggestions
Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch>
1 parent 2dc69ab commit 61846cd

2 files changed

Lines changed: 15 additions & 10 deletions

File tree

bundles/org.openhab.core/src/main/java/org/openhab/core/util/LightModel.java

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -205,7 +205,7 @@ public LightModel() {
205205
* @param supportsBrightness true if the light supports brightness control
206206
* @param supportsColorTemperature true if the light supports color temperature control
207207
* @param supportsColor true if the light supports color control
208-
* @param rgbLinkedToBrightness true if RGB vales are linked with the 'B' part of the {@link HSBType}
208+
* @param rgbLinkedToBrightness true if RGB values are linked with the 'B' part of the {@link HSBType}
209209
* @param supportsRgbWhite true if the light supports RGBW rather than RGB color control
210210
*/
211211
public LightModel(boolean supportsBrightness, boolean supportsColorTemperature, boolean supportsColor,
@@ -221,7 +221,7 @@ public LightModel(boolean supportsBrightness, boolean supportsColorTemperature,
221221
* @param supportsBrightness true if the light supports brightness control
222222
* @param supportsColorTemperature true if the light supports color temperature control
223223
* @param supportsColor true if the light supports color control
224-
* @param rgbLinkedToBrightness true if RGB vales are linked with the 'B' part of the {@link HSBType}
224+
* @param rgbLinkedToBrightness true if RGB values are linked with the 'B' part of the {@link HSBType}
225225
* @param supportsRgbWhite true if the light supports RGBW rather than RGB color control
226226
* @param minimumOnBrightness the minimum brightness percent to consider as light "ON"
227227
* @param warmestMired the 'warmest' white color temperature in Mired
@@ -366,7 +366,9 @@ public void configSetMiredWarmest(double warmestMired) throws IllegalArgumentExc
366366
* brightness.</li>
367367
* </ul>
368368
*
369-
* @param rgbLinkedToBrightness true if RGB values are raw
369+
* @param rgbLinkedToBrightness true if RGB values are linked to brightness (i.e., relate to all HSB parts and will
370+
* influence and depend on brightness); false if RGB values only relate to hue and saturation and do not
371+
* influence or depend on brightness
370372
*/
371373
public void configSetRgbLinkedToBrightness(boolean rgbLinkedToBrightness) {
372374
model.configSetRgbLinkedToBrightness(rgbLinkedToBrightness);
@@ -433,7 +435,7 @@ public void configSetSupportsRgbWhite(boolean supportsRgbWhite) {
433435
/**
434436
* Runtime State: get the color temperature or return null if the capability is not supported
435437
*
436-
* @return QuantityType in Mired representing the color temperature, or null if not supported
438+
* @return QuantityType in Kelvin representing the color temperature, or null if not supported
437439
*/
438440
public @Nullable QuantityType<?> getColorTemperature() {
439441
return model.getColorTemperature();

bundles/org.openhab.core/src/main/java/org/openhab/core/util/LightModelAbstractLogicImpl.java

Lines changed: 9 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -77,7 +77,7 @@ abstract class LightModelAbstractLogicImpl {
7777
* @param supportsBrightness true if the light supports brightness control
7878
* @param supportsColorTemperature true if the light supports color temperature control
7979
* @param supportsColor true if the light supports color control
80-
* @param rgbLinkedToBrightness true if RGB vales are linked with the 'B' part of the {@link HSBType}
80+
* @param rgbLinkedToBrightness true if RGB values are linked with the 'B' part of the {@link HSBType}
8181
* @param supportsRgbWhite true if the light supports RGBW rather than RGB color control
8282
* @param minimumOnBrightness the minimum brightness percent to consider as light "ON"
8383
* @param warmestMired the 'warmest' white color temperature in Mired
@@ -248,10 +248,12 @@ void configSetMiredWarmest(double warmestMired) throws IllegalArgumentException
248248
* brightness.</li>
249249
* </ul>
250250
*
251-
* @param supportsRgbDimming true if RGB values are raw
251+
* @param rgbLinkedToBrightness true if RGB values are linked to brightness (i.e., relate to all HSB parts and will
252+
* influence and depend on brightness); false if RGB values only relate to hue and saturation and do not
253+
* influence or depend on brightness
252254
*/
253-
void configSetRgbLinkedToBrightness(boolean supportsRgbDimming) {
254-
this.rgbLinkedToBrightness = supportsRgbDimming;
255+
void configSetRgbLinkedToBrightness(boolean rgbLinkedToBrightness) {
256+
this.rgbLinkedToBrightness = rgbLinkedToBrightness;
255257
}
256258

257259
/**
@@ -320,7 +322,7 @@ HSBType getColor() {
320322
/**
321323
* Runtime State: get the color temperature or return null if the capability is not supported
322324
*
323-
* @return QuantityType in Kelvin, or null if not supported
325+
* @return QuantityType in Kelvin representing the color temperature, or null if not supported
324326
*/
325327
@Nullable
326328
QuantityType<?> getColorTemperature() {
@@ -366,7 +368,8 @@ PercentType getColorTemperaturePercent() {
366368
/**
367369
* Runtime State: get the on/off state.
368370
*
369-
* @param forceChannelVisible if present and true, return a non-null value even if brightness or color are supported.
371+
* @param forceChannelVisible if present and true, return a non-null value even if brightness or color are
372+
* supported.
370373
* @return OnOffType representing the on/off state.
371374
*/
372375
@Nullable

0 commit comments

Comments
 (0)