copilot review

Signed-off-by: Mark Herwege <mark.herwege@telenet.be>

Author: mherwege

bundles/org.openhab.core.sitemap/src/main/java/org/openhab/core/sitemap/internal/registry/SitemapFactoryImpl.java

@@ -45,11 +45,10 @@
 import org.openhab.core.sitemap.internal.VideoImpl;
 import org.openhab.core.sitemap.internal.WebviewImpl;
 import org.openhab.core.sitemap.registry.SitemapFactory;
-import org.openhab.core.sitemap.registry.SitemapRegistry;
 import org.osgi.service.component.annotations.Component;
 
 /**
- * The {@link SitemapFactoryImpl} implements the {@link SitemapRegistry}
+ * The {@link SitemapFactoryImpl} implements the {@link SitemapFactory}
  *
  * @author Mark Herwege - Initial contribution
  */

bundles/org.openhab.core.ui/src/main/java/org/openhab/core/ui/internal/proxy/ProxyServletService.java

@@ -258,7 +258,7 @@ URI uriFromRequest(HttpServletRequest request) {
             }
 
             try {
-                uri = createURIFromString(uriString != null ? uriString : "");
+                uri = createURIFromString(uriString);
                 request.setAttribute(ATTR_URI, uri);
                 return uri;
             } catch (MalformedURLException | URISyntaxException ex) {
@@ -275,7 +275,10 @@ URI uriFromRequest(HttpServletRequest request) {
         return sitemapRegistry.get(sitemapName);
     }
 
-    private URI createURIFromString(String url) throws MalformedURLException, URISyntaxException {
+    private URI createURIFromString(@Nullable String url) throws MalformedURLException, URISyntaxException {
+        if (url == null) {
+            throw new MalformedURLException();
+        }
         URI uri = new URI(url);
         // URI in this context should be valid URL. Therefore before returning URI, create URL,
         // which validates the string.