Support openHAB 5.3-SNAPSHOT#539
Merged
Merged
Conversation
jimtng
force-pushed
the
jruby-10.0.6.0
branch
6 times, most recently
from
33c2e58 to
aa8fb17
Compare
Contributor
Author
|
our CI succeeded on 5.2.0.M3 |
Contributor
Author
|
Something between M4 and M5 broke our CI (even on jruby-10.0.5.0) |
jimtng
force-pushed
the
jruby-10.0.6.0
branch
2 times, most recently
from
ccf3a61 to
8d7f24f
Compare
Signed-off-by: Jimmy Tanagra <jcode@tanagra.id.au>
Signed-off-by: Jimmy Tanagra <jcode@tanagra.id.au>
Contributor
Author
|
It appears that the changes in openhab/openhab-core#5069 caused the rspec to fail. I've made adjustments to adapt to the changes, but I'd admit that I'm not super familiar with the SynchronousExecutor and why the code that I removed (checking if it's the same thread) was originally written. |
jimtng
changed the title
jimtng
added
bug
Signed-off-by: Jimmy Tanagra <jcode@tanagra.id.au>
jimtng
force-pushed
the
jruby-10.0.6.0
branch
2 times, most recently
from
ecdf93b to
b02d7d9
Compare
Signed-off-by: Jimmy Tanagra <jcode@tanagra.id.au>
Since openHAB 5.2.0 rake was unable to start openhab. karaf.log contained There is a Root instance already running with name openhab and pid 2176108. If you know what you are doing and want to force the run anyway, export CHECK_ROOT_INSTANCE_RUNNING=false and re run the command. Signed-off-by: Jimmy Tanagra <jcode@tanagra.id.au>
jimtng
added
enhancement
jimtng
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is split into two commits: one to make the spec work on 5.2.0-snapshot, and the other one to upgrade to jruby-10.0.6.0
Addon upgrade: openhab/openhab-addons#20951