[rules] runRule: Pass args as Java HashMap instead of JS object (#528)

When rule A calls rule B through `rules.runRule` and passes arguments,
rule B executes in its own, dedicated thread.
This causes an illegal multi-threaded access to the args object, so
instead of passing the args object directly, construct a Java HashMap
from it.

Related to openhab/openhab-core#5069.

Signed-off-by: Florian Hotze <dev@florianhotze.com>

Author: florian-h05

src/rules/rules.js

@@ -69,6 +69,8 @@
 const SCRIPT_TYPE = 'application/javascript';
 const GENERATED_RULE_ITEM_TAG = 'GENERATED_RULE_ITEM';
 
+const HashMap = Java.type('java.util.HashMap');
+
 const items = require('../items/items');
 const { randomUUID, jsArrayToJavaSet } = require('../utils');
 const log = require('../log')('rules');
@@ -179,11 +181,11 @@ function removeRule (uid) {
   *
   * @memberof rules
   * @param {string} uid the UID of the rule to run
-  * @param {object} [args={}] args optional dict of data to pass to the called rule
-  * @param {boolean} [cond=true] when true, the called rule will only run if it's conditions are met
+  * @param {Record<string, unknown>} [args={}] args optional dict of data to pass to the called rule
+  * @param {boolean} [conditions=true] when true, the called rule will only run if it's conditions are met
   * @throws {Error} throws an error if the rule does not exist or is not initialized.
   */
-function runRule (uid, args = {}, cond = true) {
+function runRule (uid, args = {}, conditions = true) {
   const status = ruleManager.getStatus(uid);
   if (!status) {
     throw Error('There is no rule with UID ' + uid);
@@ -192,7 +194,7 @@ function runRule (uid, args = {}, cond = true) {
     throw Error('Rule ' + uid + ' is UNINITIALIZED');
   }
 
-  ruleManager.runNow(uid, cond, args);
+  ruleManager.runNow(uid, conditions, new HashMap(args));
 }
 
 /**

types/rules/rules.d.ts

@@ -168,11 +168,11 @@ export function removeRule(uid: string): boolean;
   *
   * @memberof rules
   * @param {string} uid the UID of the rule to run
-  * @param {object} [args={}] args optional dict of data to pass to the called rule
-  * @param {boolean} [cond=true] when true, the called rule will only run if it's conditions are met
+  * @param {Record<string, unknown>} [args={}] args optional dict of data to pass to the called rule
+  * @param {boolean} [conditions=true] when true, the called rule will only run if it's conditions are met
   * @throws {Error} throws an error if the rule does not exist or is not initialized.
   */
-export function runRule(uid: string, args?: object, cond?: boolean): void;
+export function runRule(uid: string, args?: Record<string, unknown>, conditions?: boolean): void;
 /**
   * Tests to see if the rule with the given UID is enabled or disabled. Throws
   * and error if the rule doesn't exist.