refactor: code refactoring

Author: anthbel

README.md

@@ -1,4 +1,4 @@
-# openimis-be-invoice_payment_py
+# openimis-be-invoice_py
 
 OpenIMIS backend module for invoices, bills, and payments.
 

invoice/migrations/0014_bill_code_sequence.py

@@ -158,6 +158,11 @@ def apply_bill_code_trigger(apps, schema_editor):
         _pg_apply(schema_editor)
     elif vendor == 'microsoft':
         _mssql_apply(schema_editor)
+    else:
+        raise RuntimeError(
+            f"Unsupported DB vendor '{vendor}' for bill code trigger migration; "
+            "only 'postgresql' and 'microsoft' are supported."
+        )
 
 
 def reverse_bill_code_trigger(apps, schema_editor):
@@ -166,6 +171,11 @@ def reverse_bill_code_trigger(apps, schema_editor):
         _pg_reverse(schema_editor)
     elif vendor == 'microsoft':
         _mssql_reverse(schema_editor)
+    else:
+        raise RuntimeError(
+            f"Unsupported DB vendor '{vendor}' for bill code trigger reverse migration; "
+            "only 'postgresql' and 'microsoft' are supported."
+        )
 
 
 class Migration(migrations.Migration):

invoice/services/bill.py

@@ -1,6 +1,8 @@
 import decimal
 from typing import Union, List
 
+from simple_history.utils import bulk_create_with_history
+
 from invoice.models import Bill, BillItem
 from core.services import BaseService
 from invoice.services.billLineItem import BillLineItemService
@@ -84,7 +86,7 @@ def _evaluate_generic_types(self, bill_data):
 
     @classmethod
     def bulk_create_bills(cls, bills):
-        created = Bill.objects.bulk_create(bills, batch_size=BULK_CREATE_BATCH_SIZE)
+        created = bulk_create_with_history(bills, Bill, batch_size=BULK_CREATE_BATCH_SIZE)
         # Re-fetch codes assigned by DB trigger for rows that had empty codes.
         empty_code_ids = [b.id for b in created if not b.code]
         if empty_code_ids:
@@ -99,4 +101,4 @@ def bulk_create_bills(cls, bills):
 
     @classmethod
     def bulk_create_bill_items(cls, bill_items):
-        return BillItem.objects.bulk_create(bill_items, batch_size=BULK_CREATE_BATCH_SIZE)
+        return bulk_create_with_history(bill_items, BillItem, batch_size=BULK_CREATE_BATCH_SIZE)