fix(benefit-plan): fix schema validation and action button tooltips

- Correct the action type value for `BENEFIT_PLAN_SCHEMA_SET_VALID` in the reducer to prevent it from overriding the name validation.
- Initialize `validationFields` in the default reducer state.
- Handle undefined schema validation state gracefully in `isValid` check.
- Hide tooltips on the 'delete' and 'stop' action buttons when they are disabled.
- Remove `displayZero` from the max beneficiaries input field to improve usability.

Author: delcroip

src/components/BenefitPlanHeadPanel.jsx

@@ -131,7 +131,6 @@ class BenefitPlanHeadPanel extends FormPanel {
         <StyledGridItem size={3}>
           <NumberInput
             min={0}
-            displayZero
             module="socialProtection"
             label="benefitPlan.maxBeneficiaries"
             onChange={(v) => {

src/pages/BenefitPlanPage.jsx

@@ -115,7 +115,7 @@ function BenefitPlanPage({
   };
 
   const isValid = () => (
-    isBenefitPlanNameValid && isBenefitPlanCodeValid && isBenefitPlanSchemaValid
+    isBenefitPlanNameValid && isBenefitPlanCodeValid && (isBenefitPlanSchemaValid ?? true)
   );
 
   const doesBenefitPlanChange = () => {
@@ -201,14 +201,14 @@ function BenefitPlanPage({
             icon: <DeleteIcon />,
             handler: openDeleteBenefitPlanConfirmDialog,
             disabled: !benefitPlan?.id || submittingMutation,
-            tooltip: formatMessage(intl, 'socialProtection', 'benefitPlan.deleteButton.tooltip'),
+            tooltip: (!benefitPlan?.id || submittingMutation) ? undefined : formatMessage(intl, 'socialProtection', 'benefitPlan.deleteButton.tooltip'),
           },
           {
             name: 'stop',
             icon: <PauseIcon />,
             handler: openStopBenefitPlanConfirmDialog,
             disabled: !benefitPlan?.id || submittingMutation,
-            tooltip: formatMessage(intl, 'socialProtection', 'benefitPlan.closeButton.tooltip'),
+            tooltip: (!benefitPlan?.id || submittingMutation) ? undefined : formatMessage(intl, 'socialProtection', 'benefitPlan.closeButton.tooltip'),
           },
         ]}
       />

src/reducer.js

@@ -29,7 +29,7 @@ export const ACTION_TYPE = {
   BENEFIT_PLAN_SCHEMA_FIELDS_VALIDATION: 'BENEFIT_PLAN_SCHEMA_FIELDS_VALIDATION',
   BENEFIT_PLAN_CODE_SET_VALID: 'BENEFIT_PLAN_CODE_SET_VALID',
   BENEFIT_PLAN_NAME_SET_VALID: 'BENEFIT_PLAN_NAME_SET_VALID',
-  BENEFIT_PLAN_SCHEMA_SET_VALID: 'BENEFIT_PLAN_NAME_SET_VALID',
+   BENEFIT_PLAN_SCHEMA_SET_VALID: 'BENEFIT_PLAN_SCHEMA_SET_VALID',
   SEARCH_BENEFICIARIES: 'BENEFICIARY_BENEFICIARIES',
   SEARCH_PROJECT_BENEFICIARIES: 'PROJECT_BENEFICIARIES',
   SEARCH_GROUP_BENEFICIARIES: 'GROUP_BENEFICIARY_GROUP_BENEFICIARIES',
@@ -142,6 +142,11 @@ function reducer(
     projectBeneficiariesPageInfo: {},
     projectBeneficiariesTotalCount: 0,
     errorProjectBeneficiaries: null,
+    validationFields: {
+      benefitPlanName: { isValid: true },
+      benefitPlanCode: { isValid: true },
+      benefitPlanSchema: { isValid: true },
+    },
   },
   action,
 ) {