Skip to content

track_metrics_enabled: docs say default true, actual default is false #558

Description

@gmarzot

AdminConfig::trackMetricsEnabled{false} in src/config/Config.h; the resolver only overrides it when the YAML key is present. So /metrics/track returns 503 on a relay that does not set it.

Two places document the opposite:

  • docs/metrics.md: "Requires admin.track_metrics_enabled (default true)"
  • ParsedConfig.h: "Enable per-track counting and the /metrics/track endpoint (default true)"

Off by default is the right posture — per-object counting should be opt-in. So the ask is to fix the two doc strings to say false, not to change the code.

The CI relay sets it explicitly in docker/config.docker.yaml (#539), so nothing here depends on the default.

Seen on v0.2.1-36-g4915b551.

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Type

    Fields

    Priority

    None yet

    Severity

    None yet

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions