admin: honor the ?limit= parameter on /metrics/track - #561
Merged
Conversation
The parsed value was validated and discarded, so every scrape used admin.track_metrics_endpoint_default_limit and the 400 body told callers to raise a limit that raising did not change. Also drop the doc's claim that an over-max limit is clamped; it is a 400. Fixes #560
afrind
force-pushed
the
fix/track-metrics-limit-param
branch
from
August 12, 2026 19:03
b71fbfa to
f196b45
Compare
gmarzot
self-requested a review
August 13, 2026 00:29
gmarzot
approved these changes
Aug 13, 2026
gmarzot
left a comment
gmarzot
left a comment
Contributor
There was a problem hiding this comment.
@gmarzot reviewed 3 files and all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on gmarzot).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The parsed value was validated and discarded, so every scrape used admin.track_metrics_endpoint_default_limit and the 400 body told callers to raise a limit that raising did not change.
Also drop the doc's claim that an over-max limit is clamped; it is a 400.
Fixes #560
This change is