Core-1308: Highlight markers have textContent (#2641)

[CORE-1308]

Hide data-for-screenreaders

Author: RoyEJohnson

package.json

@@ -9,7 +9,7 @@
     "@craco/craco": "<7",
     "@formatjs/intl-pluralrules": "^5.2.3",
     "@openstax/event-capture-client": "^2.0.2",
-    "@openstax/highlighter": "https://github.com/openstax/highlighter#1.16.3",
+    "@openstax/highlighter": "https://github.com/openstax/highlighter#1.16.4b",
     "@openstax/open-search-client": "0.1.0-build.7",
     "@openstax/ts-utils": "1.19.0",
     "@openstax/ui-components": "openstax/ui-components#1.14.0",

src/app/content/__snapshots__/routes.spec.tsx.snap

@@ -550,6 +550,19 @@ Array [
   transform: rotate(90deg);
 }
 
+.c4 [data-for-screenreaders="true"] {
+  position: absolute;
+  width: 1px;
+  height: 1px;
+  padding: 0;
+  margin: -1px;
+  overflow: hidden;
+  -webkit-clip: rect(0,0,0,0);
+  clip: rect(0,0,0,0);
+  white-space: nowrap;
+  border: 0;
+}
+
 .c4 .os-figure,
 .c4 .os-figure:last-child {
   margin-bottom: 5px;
@@ -730,20 +743,6 @@ Array [
   .c4 .search-highlight[aria-current] .search-highlight {
     background-color: unset;
   }
-
-  .c4 .search-highlight [data-for-screenreaders="true"]::before {
-    content: attr(data-message);
-    position: absolute;
-    width: 1px;
-    height: 1px;
-    padding: 0;
-    margin: -1px;
-    overflow: hidden;
-    -webkit-clip: rect(0,0,0,0);
-    clip: rect(0,0,0,0);
-    white-space: nowrap;
-    border: 0;
-  }
 }
 
 @media screen and (max-width:90em) {

src/app/content/components/Page/PageContent.tsx

@@ -181,14 +181,13 @@ export default styled(MainContent)`
           background-color: unset;
         }
       }
-
-      [data-for-screenreaders="true"]::before {
-        content: attr(data-message);
-        ${hiddenButAccessible}
-      }
     }
   }
 
+  [data-for-screenreaders="true"] {
+    ${hiddenButAccessible}
+  }
+
   .os-figure,
   .os-figure:last-child {
     margin-bottom: 5px; /* fix double scrollbar bug */

src/app/content/components/__snapshots__/Content.spec.tsx.snap

@@ -976,6 +976,19 @@ Array [
   transform: rotate(90deg);
 }
 
+.c73 [data-for-screenreaders="true"] {
+  position: absolute;
+  width: 1px;
+  height: 1px;
+  padding: 0;
+  margin: -1px;
+  overflow: hidden;
+  -webkit-clip: rect(0,0,0,0);
+  clip: rect(0,0,0,0);
+  white-space: nowrap;
+  border: 0;
+}
+
 .c73 .os-figure,
 .c73 .os-figure:last-child {
   margin-bottom: 5px;
@@ -2387,20 +2400,6 @@ Array [
   .c73 .search-highlight[aria-current] .search-highlight {
     background-color: unset;
   }
-
-  .c73 .search-highlight [data-for-screenreaders="true"]::before {
-    content: attr(data-message);
-    position: absolute;
-    width: 1px;
-    height: 1px;
-    padding: 0;
-    margin: -1px;
-    overflow: hidden;
-    -webkit-clip: rect(0,0,0,0);
-    clip: rect(0,0,0,0);
-    white-space: nowrap;
-    border: 0;
-  }
 }
 
 @media screen and (max-width:50em) {
@@ -8288,6 +8287,19 @@ Array [
   transform: rotate(90deg);
 }
 
+.c73 [data-for-screenreaders="true"] {
+  position: absolute;
+  width: 1px;
+  height: 1px;
+  padding: 0;
+  margin: -1px;
+  overflow: hidden;
+  -webkit-clip: rect(0,0,0,0);
+  clip: rect(0,0,0,0);
+  white-space: nowrap;
+  border: 0;
+}
+
 .c73 .os-figure,
 .c73 .os-figure:last-child {
   margin-bottom: 5px;
@@ -9546,20 +9558,6 @@ Array [
   .c73 .search-highlight[aria-current] .search-highlight {
     background-color: unset;
   }
-
-  .c73 .search-highlight [data-for-screenreaders="true"]::before {
-    content: attr(data-message);
-    position: absolute;
-    width: 1px;
-    height: 1px;
-    padding: 0;
-    margin: -1px;
-    overflow: hidden;
-    -webkit-clip: rect(0,0,0,0);
-    clip: rect(0,0,0,0);
-    white-space: nowrap;
-    border: 0;
-  }
 }
 
 @media screen and (max-width:50em) {

yarn.lock

@@ -5259,9 +5259,9 @@
   dependencies:
     uuid "^8.3.2"
 
-"@openstax/highlighter@https://github.com/openstax/highlighter#1.16.3":
-  version "1.16.3"
-  resolved "https://github.com/openstax/highlighter#500e0bc4331267c2b565c04c5856eefc3415acf5"
+"@openstax/highlighter@https://github.com/openstax/highlighter#1.16.4b":
+  version "1.16.4"
+  resolved "https://github.com/openstax/highlighter#702b3c1241106505240df188b3113b92d29dca5b"
   dependencies:
     "@openstax/highlights-client" "0.2.3"
     change-case "^4.0.0"