Skip to content

Commit 2a71a53

Browse files
OpenStaxClaudeclaudeCopilot
authored andcommitted
Address final Copilot review comments
- Fix Checkbox.css: Change 'Highlight' to 'highlight' for stylelint compliance CSS keywords are case-insensitive, using lowercase for consistency - Fix Modal.tsx: Add --link-hover variable alongside --link-hover-color Ensures compatibility with both Modal.css and Typography link components that use different variable names for hover colors 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com> Co-Authored-By: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
1 parent 39ddbc2 commit 2a71a53

5 files changed

Lines changed: 7 additions & 1 deletion

File tree

src/app/components/Checkbox.css

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -55,7 +55,7 @@
5555
background-color: var(--checkbox-focus-bg, #f1f1f1); /* theme.color.neutral.pageBackground */
5656

5757
/* Browser default focus outline */
58-
outline: 0.2rem auto Highlight;
58+
outline: 0.2rem auto highlight;
5959
/* stylelint-disable-next-line declaration-block-no-duplicate-properties */
6060
outline: 0.2rem auto -webkit-focus-ring-color; /* Fallback for webkit browsers */
6161
}

src/app/components/Modal/Modal.tsx

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -56,6 +56,7 @@ export function Card(
5656
style={{
5757
'--text-color': theme.color.text.default,
5858
'--link-color': linkColor,
59+
'--link-hover': linkHover,
5960
'--link-hover-color': linkHover,
6061
...style,
6162
} as React.CSSProperties}

src/app/components/Modal/__snapshots__/Modal.spec.tsx.snap

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,7 @@ exports[`Modal matches snapshot 1`] = `
1717
style={
1818
Object {
1919
"--link-color": "#027EB5",
20+
"--link-hover": "#0064A0",
2021
"--link-hover-color": "#0064A0",
2122
"--text-color": "#424242",
2223
}
@@ -107,6 +108,7 @@ exports[`Modal matches snapshot with children 1`] = `
107108
style={
108109
Object {
109110
"--link-color": "#027EB5",
111+
"--link-hover": "#0064A0",
110112
"--link-hover-color": "#0064A0",
111113
"--text-color": "#424242",
112114
}

src/app/content/highlights/components/__snapshots__/ConfirmationModal.spec.tsx.snap

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -107,6 +107,7 @@ exports[`ConfirmationModal matches snapshot 1`] = `
107107
style={
108108
Object {
109109
"--link-color": "#027EB5",
110+
"--link-hover": "#0064A0",
110111
"--link-hover-color": "#0064A0",
111112
"--text-color": "#424242",
112113
}

src/app/errors/components/__snapshots__/ErrorModal.spec.tsx.snap

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -66,6 +66,7 @@ exports[`ErrorModal matches snapshot 1`] = `
6666
style={
6767
Object {
6868
"--link-color": "#027EB5",
69+
"--link-hover": "#0064A0",
6970
"--link-hover-color": "#0064A0",
7071
"--text-color": "#424242",
7172
}
@@ -252,6 +253,7 @@ exports[`ErrorModal matches snapshots with recorded error ids 1`] = `
252253
style={
253254
Object {
254255
"--link-color": "#027EB5",
256+
"--link-hover": "#0064A0",
255257
"--link-hover-color": "#0064A0",
256258
"--text-color": "#424242",
257259
}

0 commit comments

Comments
 (0)