Commit bb3abd5
Remove redundant CSS variables from Footer component
Following the same pattern as NavBar, removed CSS variables that were:
- Set to hardcoded static color values in JSX
- Had identical fallback values in CSS
- Not derived from theme.ts
- Never changed at runtime (hardcoded in original styled-components)
Removed redundant variables:
- --footer-top-bg (was '#424242', now plain CSS)
- --footer-bottom-bg (was '#3b3b3b', now plain CSS)
These colors were hardcoded in the original styled-components (not from theme),
so they should be plain CSS values, not CSS variables.
Kept theme-derived variables (correct usage):
- --footer-text-color (from theme.color.text.label)
- --footer-social-icon-bg (from theme.color.primary.gray.light)
- --footer-social-icon-color (computed hex value)
🤖 Generated with [Claude Code](https://claude.com/claude-code)
Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>1 parent 2500e7d commit bb3abd5
2 files changed
Lines changed: 5 additions & 20 deletions
File tree
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
42 | 42 | | |
43 | 43 | | |
44 | 44 | | |
45 | | - | |
| 45 | + | |
46 | 46 | | |
47 | 47 | | |
48 | 48 | | |
| |||
348 | 348 | | |
349 | 349 | | |
350 | 350 | | |
351 | | - | |
| 351 | + | |
352 | 352 | | |
353 | 353 | | |
354 | 354 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
368 | 368 | | |
369 | 369 | | |
370 | 370 | | |
371 | | - | |
372 | | - | |
373 | | - | |
374 | | - | |
375 | | - | |
376 | | - | |
| 371 | + | |
377 | 372 | | |
378 | 373 | | |
379 | 374 | | |
| |||
384 | 379 | | |
385 | 380 | | |
386 | 381 | | |
387 | | - | |
388 | | - | |
389 | | - | |
390 | | - | |
391 | | - | |
392 | | - | |
| 382 | + | |
393 | 383 | | |
394 | 384 | | |
395 | 385 | | |
| |||
533 | 523 | | |
534 | 524 | | |
535 | 525 | | |
536 | | - | |
537 | | - | |
538 | | - | |
539 | | - | |
540 | | - | |
541 | | - | |
| 526 | + | |
542 | 527 | | |
543 | 528 | | |
544 | 529 | | |
| |||
0 commit comments