Skip to content

Clean up some NSLog calls - #741

Merged
zonble merged 1 commit into
openvanilla:masterfrom
lukhnos:logging-cleanup
Nov 15, 2025
Merged

Clean up some NSLog calls#741
zonble merged 1 commit into
openvanilla:masterfrom
lukhnos:logging-cleanup

Conversation

@lukhnos

@lukhnos lukhnos commented Nov 15, 2025

Copy link
Copy Markdown
Contributor

No description provided.

@lukhnos
lukhnos requested review from Copilot and zonble November 15, 2025 02:13
@gemini-code-assist

Copy link
Copy Markdown

Summary of Changes

Hello @lukhnos, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on refining the logging within the KeyHandler.mm file. It enhances the precision of an existing warning message and removes two redundant debug NSLog calls, contributing to a cleaner and more focused codebase by eliminating unnecessary output and improving diagnostic messages.

Highlights

  • Logging Clarity: The NSLog warning message related to _grid being used after release has been updated for improved clarity, changing a generic 'used after release????' to a more specific 'warning: _grid used after release'.
  • Debug Log Removal: Two debug NSLog statements, which were logging Preferences.allowMovingCursorWhenChoosingCandidates and input.inputText, have been removed from the _handleCandidateState: method, streamlining the code and reducing unnecessary output.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR improves logging hygiene in KeyHandler.mm by making one warning message clearer and removing two unnecessary debug NSLog statements.

  • Improved clarity of a warning message about _grid usage after release
  • Removed debug logging statements that were likely left over from development

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request cleans up some NSLog calls. The changes are good, especially removing the debug logs. I've also noticed a potential logic issue in setInputMode: where a nullptr _grid is not handled correctly, which could lead to a crash. I've added a suggestion to make the code more robust.

@zonble
zonble merged commit 6f75d36 into openvanilla:master Nov 15, 2025
7 checks passed
@lukhnos
lukhnos deleted the logging-cleanup branch January 11, 2026 00:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants