Clean up some NSLog calls - #741
Conversation
Summary of ChangesHello @lukhnos, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request focuses on refining the logging within the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Pull Request Overview
This PR improves logging hygiene in KeyHandler.mm by making one warning message clearer and removing two unnecessary debug NSLog statements.
- Improved clarity of a warning message about
_gridusage after release - Removed debug logging statements that were likely left over from development
There was a problem hiding this comment.
Code Review
This pull request cleans up some NSLog calls. The changes are good, especially removing the debug logs. I've also noticed a potential logic issue in setInputMode: where a nullptr _grid is not handled correctly, which could lead to a crash. I've added a suggestion to make the code more robust.
dd36373 to
d54b844
Compare
No description provided.