Minor copyediting - #744
Conversation
This makes sure that title-cases are used where needed.
Summary of ChangesHello @lukhnos, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request focuses on enhancing the user interface's textual presentation by applying consistent title-casing to several strings and refining localization keys. These changes aim to improve the overall polish and readability of the application's messages and menu items, ensuring a more professional and user-friendly experience. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request focuses on minor copyediting for localization strings to improve consistency. The changes primarily involve updating localization keys to use Title Case where appropriate, and refactoring one key to be more descriptive. These modifications have been applied consistently across the relevant Swift files and localization files (en and zh-Hant). The changes are correct and improve the overall code quality and maintainability by making localization keys more consistent and readable. I have no further suggestions.
There was a problem hiding this comment.
Pull Request Overview
This PR standardizes the capitalization of user-facing strings by applying proper title-case formatting to localized string keys and their English translations, improving consistency across the application's UI elements.
- Updates localized string keys to use title-case instead of sentence-case
- Ensures all three locale files (Base, en, zh-Hant) and corresponding Swift code references are synchronized
- Corrects hyphenation in compound adjectives (e.g., "Full-width" → "Full-Width")
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| Source/Base.lproj/Localizable.strings | Updates five localization keys to use proper title-case formatting |
| Source/en.lproj/Localizable.strings | Matches Base locale with title-cased keys and English translations |
| Source/zh-Hant.lproj/Localizable.strings | Synchronizes Traditional Chinese locale with updated title-cased keys |
| Source/InputState.swift | Updates NSLocalizedString calls to use new title-cased keys for Roman number menu items |
| Source/InputMethodController.swift | Updates NSLocalizedString calls for Chinese conversion menu item and notification messages |
| Source/AppDelegate.swift | Updates NSLocalizedString call for user phrase file error dialog title |
This makes sure that title-cases are used where needed.