Skip to content

Keep BPMFBase.txt sorted by reading. - #892

Merged
lukhnos merged 1 commit into
openvanilla:masterfrom
zonble:master
Aug 6, 2026
Merged

Keep BPMFBase.txt sorted by reading.#892
lukhnos merged 1 commit into
openvanilla:masterfrom
zonble:master

Conversation

@zonble

@zonble zonble commented Aug 6, 2026

Copy link
Copy Markdown
Contributor

The character map was not in a correct order. Fixed.

@lukhnos lukhnos left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@lukhnos
lukhnos merged commit 69bbdea into openvanilla:master Aug 6, 2026
7 checks passed
Comment thread Source/Data/BPMFBase.txt
@xatier

xatier commented Aug 6, 2026

Copy link
Copy Markdown
Contributor

@lukhnos I'm under the impression that we typically don't adjust the orders in this file? I just noticed that two characters may be put at incorrect order?

Comment thread Source/Data/BPMFBase.txt
@lukhnos

lukhnos commented Aug 6, 2026

Copy link
Copy Markdown
Contributor

@lukhnos I'm under the impression that we typically don't adjust the orders in this file? I just noticed that two characters may be put at incorrect order?

Good call. After your comement I checked the built data-plain-bpmf.txt, and there are three entries whose orders changed. Just made #894 to make sure that the built data for Plain Bopomofo maintains the same order as before.

zonble pushed a commit that referenced this pull request Aug 6, 2026
This ensures the built `data-plain-bpmf.txt` maintains the same order
before #892 was merged.
@xatier

xatier commented Aug 6, 2026

Copy link
Copy Markdown
Contributor

@lukhnos thanks for the prompt reply. I was just wondering why the "new characters" are not "append only". :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants