Skip to content

Commit 597bdaf

Browse files
committed
🧪 Update tests
Signed-off-by: ff137 <ff137@proton.me>
1 parent 3fffe51 commit 597bdaf

2 files changed

Lines changed: 25 additions & 9 deletions

File tree

acapy_agent/revocation_anoncreds/models/tests/test_issuer_cred_rev_record.py

Lines changed: 22 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,5 @@
11
from unittest import IsolatedAsyncioTestCase
22

3-
from ....storage.base import StorageNotFoundError
43
from ....utils.testing import create_test_profile
54
from .. import issuer_cred_rev_record as test_module
65
from ..issuer_cred_rev_record import IssuerCredRevRecord
@@ -84,13 +83,30 @@ async def test_rec_ops(self):
8483
)
8584
)
8685

86+
await recs[1].set_state( # Save extra record
87+
session,
88+
IssuerCredRevRecord.STATE_REVOKED,
89+
)
90+
# Fetch cred rev id as string
91+
assert await IssuerCredRevRecord.retrieve_by_ids(
92+
session, rev_reg_id=REV_REG_ID, cred_rev_id="1"
93+
) == [recs[0]]
94+
95+
# Fetch cred rev id as list
96+
assert await IssuerCredRevRecord.retrieve_by_ids(
97+
session, rev_reg_id=REV_REG_ID, cred_rev_id=["2"]
98+
) == [recs[1]]
99+
100+
# Fetch both
87101
assert (
88102
await IssuerCredRevRecord.retrieve_by_ids(
89-
session, rev_reg_id=REV_REG_ID, cred_rev_id="1"
103+
session, rev_reg_id=REV_REG_ID, cred_rev_id=["1", "2"]
90104
)
91-
== recs[0]
92-
)
93-
with self.assertRaises(StorageNotFoundError):
105+
) == recs
106+
107+
# Fetch cred rev id that doesn't exist
108+
assert (
94109
await IssuerCredRevRecord.retrieve_by_ids(
95-
session, rev_reg_id=REV_REG_ID, cred_rev_id="2"
110+
session, rev_reg_id=REV_REG_ID, cred_rev_id=["3"]
96111
)
112+
) == []

acapy_agent/revocation_anoncreds/tests/test_routes.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -348,9 +348,9 @@ async def test_get_cred_rev_record(self):
348348
test_module.web, "json_response", mock.Mock()
349349
) as mock_json_response,
350350
):
351-
mock_retrieve.return_value = mock.MagicMock(
352-
serialize=mock.MagicMock(return_value="dummy")
353-
)
351+
mock_retrieve.return_value = [
352+
mock.MagicMock(serialize=mock.MagicMock(return_value="dummy"))
353+
]
354354
result = await test_module.get_cred_rev_record(self.request)
355355

356356
mock_json_response.assert_called_once_with({"result": "dummy"})

0 commit comments

Comments
 (0)