Upgrade python to 3.13 (#3911)

jamshale · web-flow · commit d7527214a441 · 2025-12-23T09:01:20.000-08:00
* Upgrade python to 3.13

Signed-off-by: JamieHale &lt;jamiehalebc@gmail.com&gt;

* fix: Use sqlcipher3-wheels for installing pysqlcipher3

Signed-off-by: JamieHale &lt;jamiehalebc@gmail.com&gt;

* fix: Use base python image for demo image and install web.py for github repo

Signed-off-by: JamieHale &lt;jamiehalebc@gmail.com&gt;

* fix: Create list from session handle fetch_all for iterations

Signed-off-by: jamshale &lt;jamiehalebc@gmail.com&gt;

* fix: Create list from session handle fetch_all for iterations

Signed-off-by: jamshale &lt;jamiehalebc@gmail.com&gt;

* Update lock file

Signed-off-by: jamshale &lt;jamiehalebc@gmail.com&gt;

* chore: Change github action python version

Signed-off-by: jamshale &lt;jamiehalebc@gmail.com&gt;

* Update lock file after main rebase

Signed-off-by: jamshale &lt;jamiehalebc@gmail.com&gt;

* chore: some suggestions from co-pilot

Signed-off-by: jamshale &lt;jamiehalebc@gmail.com&gt;

* Remove webpy from demo dependencies. It's old and unused

Signed-off-by: jamshale &lt;jamiehalebc@gmail.com&gt;

---------

Signed-off-by: JamieHale &lt;jamiehalebc@gmail.com&gt;
Signed-off-by: jamshale &lt;jamiehalebc@gmail.com&gt;
diff --git a/.devcontainer/Dockerfile b/.devcontainer/Dockerfile
@@ -1,5 +1,5 @@
 # See here for image contents: https://github.com/microsoft/vscode-dev-containers/tree/v0.134.0/containers/python-3/.devcontainer/base.Dockerfile
-ARG VARIANT="3.12"
+ARG VARIANT="3.13"
 FROM mcr.microsoft.com/devcontainers/python:${VARIANT}
 
 ARG POETRY_VERSION="2.1.1"
diff --git a/.devcontainer/devcontainer.json b/.devcontainer/devcontainer.json
@@ -6,7 +6,7 @@
         "dockerfile": "Dockerfile",
         "context": "..",
         "args": {
-          "VARIANT": "3.12-bookworm",
+          "VARIANT": "3.13-bookworm",
           "POETRY_VERSION": "2.1.1"
         }
     },
diff --git a/.github/workflows/format.yml b/.github/workflows/format.yml
@@ -18,7 +18,7 @@ jobs:
       - uses: actions/checkout@1af3b93b6815bc44a9784bd300feb67ff0d1eeb3 # v6.0.0
       - uses: actions/setup-python@a26af69be951a213d495a4c3e4e4022e16d87065 # v5.6.0
         with:
-          python-version: "3.12"
+          python-version: "3.13"
       - name: Ruff Format Check
         uses: chartboost/ruff-action@e18ae971ccee1b2d7bbef113930f00c670b78da4 # v1.0.0
         with:
diff --git a/.github/workflows/nightly.yml b/.github/workflows/nightly.yml
@@ -18,7 +18,7 @@ jobs:
       fail-fast: false
       matrix:
         os: ["ubuntu-latest"]
-        python-version: ["3.12"]
+        python-version: ["3.13"]
 
     steps:
       - name: Checkout
diff --git a/.github/workflows/pr-tests.yml b/.github/workflows/pr-tests.yml
@@ -21,7 +21,7 @@ jobs:
     - name: Tests
       uses: ./.github/actions/run-unit-tests
       with:
-        python-version: "3.12"
+        python-version: "3.13"
         os: "ubuntu-latest"
         is_pr: "true"
 
@@ -48,5 +48,5 @@ jobs:
     - name: PostgreSQL Integration Tests
       uses: ./.github/actions/run-postgres-tests
       with:
-        python-version: "3.12"
+        python-version: "3.13"
         os: "ubuntu-latest"
diff --git a/.github/workflows/publish.yml b/.github/workflows/publish.yml
@@ -31,7 +31,7 @@ jobs:
     strategy:
       fail-fast: false
       matrix:
-        python-version: ["3.12"]
+        python-version: ["3.13"]
         arch: ["amd64", "arm64"]
         include:
           - arch: amd64
@@ -75,7 +75,7 @@ jobs:
     strategy:
       fail-fast: false
       matrix:
-        python-version: ["3.12"]
+        python-version: ["3.13"]
         image-type: ["standard", "bbs"]
         include:
           - image-type: standard
diff --git a/.github/workflows/scenario-integration-tests.yml b/.github/workflows/scenario-integration-tests.yml
@@ -56,7 +56,7 @@ jobs:
       - uses: actions/setup-python@a26af69be951a213d495a4c3e4e4022e16d87065 # v5.6.0
         if: steps.check-if-scenarios-or-src-changed.outputs.run_tests != 'false'
         with:
-          python-version: "3.12"
+          python-version: "3.13"
           cache: "poetry"
       - name: Run Scenario Tests
         if: steps.check-if-scenarios-or-src-changed.outputs.run_tests != 'false'
diff --git a/.github/workflows/sonar-merge-main.yml b/.github/workflows/sonar-merge-main.yml
@@ -20,7 +20,7 @@ jobs:
       - name: Tests
         uses: ./.github/actions/run-unit-tests
         with:
-            python-version: "3.12"
+            python-version: "3.13"
             os: "ubuntu-latest"
             is_pr: "false" 
       - name: SonarCloud Scan
diff --git a/.readthedocs.yaml b/.readthedocs.yaml
@@ -3,7 +3,7 @@ version: 2
 build:
   os: "ubuntu-24.04"
   tools:
-    python: "3.12"
+    python: "3.13"
 
 sphinx:
   builder: dirhtml
diff --git a/README.md b/README.md
@@ -1,6 +1,6 @@
 # ACA-Py -- A Cloud Agent - Python  <!-- omit in toc -->
 
-![Python](https://img.shields.io/badge/python-3.12-blue.svg)
+![Python](https://img.shields.io/badge/python-3.13-blue.svg)
 [![PyPI version](https://img.shields.io/pypi/v/acapy-agent)](https://pypi.org/project/acapy-agent/)
 [![Lines of Code](https://sonarcloud.io/api/project_badges/measure?project=openwallet-foundation_acapy&metric=ncloc)](https://sonarcloud.io/summary/new_code?id=openwallet-foundation_acapy)
 [![Coverage](https://sonarcloud.io/api/project_badges/measure?project=openwallet-foundation_acapy&metric=coverage)](https://sonarcloud.io/summary/new_code?id=openwallet-foundation_acapy)
diff --git a/acapy_agent/anoncreds/issuer.py b/acapy_agent/anoncreds/issuer.py
@@ -266,7 +266,7 @@ async def get_created_schemas(
                 },
             )
         # entry.name was stored as the schema's ID
-        return [entry.name for entry in schemas]
+        return [entry.name for entry in list(schemas)]
 
     async def credential_definition_in_wallet(
         self, credential_definition_id: str
@@ -510,7 +510,7 @@ async def get_created_credential_definitions(
                 },
             )
         # entry.name is cred def id when state == finished
-        return [entry.name for entry in credential_definition_entries]
+        return [entry.name for entry in list(credential_definition_entries)]
 
     async def match_created_credential_definitions(
         self,
diff --git a/acapy_agent/anoncreds/revocation/revocation.py b/acapy_agent/anoncreds/revocation/revocation.py
@@ -634,7 +634,7 @@ async def get_created_revocation_registry_definitions(
                 },
             )
         # entry.name was stored as the credential_definition's ID
-        return [entry.name for entry in rev_reg_defs]
+        return [entry.name for entry in list(rev_reg_defs)]
 
     async def get_created_revocation_registry_definition_state(
         self,
@@ -1259,7 +1259,7 @@ async def get_revocation_lists_with_pending_revocations(
             raise AnonCredsRevocationError("Error retrieving revocation list") from err
 
         if rev_list_entries:
-            return [entry.name for entry in rev_list_entries]
+            return [entry.name for entry in list(rev_list_entries)]
 
         return []
 
diff --git a/demo/playground/examples/Dockerfile.test.runner b/demo/playground/examples/Dockerfile.test.runner
@@ -1,4 +1,4 @@
-FROM python:3.12-slim
+FROM python:3.13-slim
 WORKDIR /usr/src/app
 
 # install poetry
diff --git a/demo/requirements.txt b/demo/requirements.txt
@@ -1,5 +1,4 @@
 asyncpg~=0.31.0
 prompt_toolkit~=3.0.51
-web.py~=0.62
 pygments~=2.19
 qrcode[pil]~=8.2
diff --git a/docker/Dockerfile b/docker/Dockerfile
@@ -1,4 +1,4 @@
-ARG python_version=3.12
+ARG python_version=3.13
 FROM python:${python_version}-slim-bookworm AS build
 
 # Install Poetry
@@ -19,7 +19,7 @@ WORKDIR /src
 
 COPY ./pyproject.toml ./poetry.lock ./
 # need to install pysqlcipher3 first to ensure build dependencies are available
-RUN pip install --no-cache-dir pysqlcipher3==1.2.0 && \
+RUN pip install --no-cache-dir sqlcipher3-wheels==0.5.5 && \
     poetry install --no-root
 
 COPY ./acapy_agent ./acapy_agent
diff --git a/docker/Dockerfile.demo b/docker/Dockerfile.demo
@@ -1,5 +1,14 @@
-ARG from_image=ghcr.io/openwallet-foundation/acapy-agent:py3.12-1.3.2
-FROM ${from_image}
+ARG python_version=3.13
+FROM python:${python_version}-slim-bookworm AS build
+
+RUN apt-get update -y && \
+    apt-get install -y --no-install-recommends \
+    libsodium23 git curl \
+    build-essential \
+    libsqlcipher-dev && \
+    apt-get install -y libpq-dev postgresql-client && \
+    apt-get clean && \
+    rm -rf /var/lib/apt/lists/*
 
 ENV ENABLE_PTVSD 0
 ENV ENABLE_PYDEVD_PYCHARM 0
@@ -25,7 +34,7 @@ COPY scripts ./scripts
 
 RUN pip3 install --no-cache-dir -e .
 
-RUN mkdir demo && chown -R aries:aries demo && chmod -R ug+rw demo
+RUN mkdir demo && chmod -R ug+rw demo
 
 # Copy and install demo code
 COPY demo/requirements.txt ./demo/requirements.txt
diff --git a/docker/Dockerfile.run b/docker/Dockerfile.run
@@ -1,5 +1,4 @@
-ARG python_version=3.12.4
-FROM python:3.12-slim-bookworm
+FROM python:3.13-slim-bookworm
 
 RUN apt-get update -y && \
     apt-get install -y --no-install-recommends \
diff --git a/docker/Dockerfile.test b/docker/Dockerfile.test
@@ -1,5 +1,4 @@
-ARG python_version=3.12.4
-FROM python:${python_version}-slim-bookworm
+FROM python:3.13-slim-bookworm
 
 RUN apt-get update -y && \
     apt-get install -y --no-install-recommends \
diff --git a/docs/features/devcontainer.md b/docs/features/devcontainer.md
@@ -44,7 +44,7 @@ To open ACA-Py in a devcontainer, we open the *root* of this repository. We can
 
 #### devcontainer.json
 
-When the [.devcontainer/devcontainer.json](https://github.com/openwallet-foundation/acapy/blob/main/.devcontainer/devcontainer.json) is opened, you will see it building... it is building a Python 3.12 image (bash shell) and loading it with all the ACA-Py requirements. We also load a few Visual Studio settings (for running Pytests and formatting with Ruff).
+When the [.devcontainer/devcontainer.json](https://github.com/openwallet-foundation/acapy/blob/main/.devcontainer/devcontainer.json) is opened, you will see it building... it is building a Python 3.13 image (bash shell) and loading it with all the ACA-Py requirements. We also load a few Visual Studio settings (for running Pytests and formatting with Ruff).
 
 ### Poetry
 
diff --git a/docs/readthedocs.yaml b/docs/readthedocs.yaml
@@ -5,7 +5,7 @@ version: 2
 build:
   os: "ubuntu-24.04"
   tools:
-    python: "3.12"
+    python: "3.13"
 
 # Build from the docs/ directory with Sphinx
 sphinx:
diff --git a/poetry.lock b/poetry.lock
diff --git a/pyproject.toml b/pyproject.toml
diff --git a/sonar-project.properties b/sonar-project.properties

Original file line number	Diff line number	Diff line change
`@@ -6,7 +6,7 @@`
`6`	`6`	`"dockerfile": "Dockerfile",`
`7`	`7`	`"context": "..",`
`8`	`8`	`"args": {`
`9`		`- "VARIANT": "3.12-bookworm",`
	`9`	`+ "VARIANT": "3.13-bookworm",`
`10`	`10`	`"POETRY_VERSION": "2.1.1"`
`11`	`11`	`}`
`12`	`12`	`},`