Skip to content

Commit 7fce466

Browse files
authored
fix: Incorrect PIN error not showing up on Android PIN verify screen (#1860)
Signed-off-by: Christian <christian.lippa@ontario.ca>
1 parent 81c7616 commit 7fce466

2 files changed

Lines changed: 7 additions & 5 deletions

File tree

.changeset/nice-emus-sin.md

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
---
2+
'@bifold/core': patch
3+
---
4+
5+
Fix incorrect pin error not appearing in new pin design on Android

packages/core/src/screens/PINVerify.tsx

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
import React, { useCallback, useEffect, useState } from 'react'
1+
import React, { useCallback, useState } from 'react'
22
import { useTranslation } from 'react-i18next'
33
import { Keyboard, StyleSheet, View } from 'react-native'
44

@@ -43,10 +43,6 @@ const PINVerify: React.FC<PINVerifyProps> = ({ setAuthenticated, usage = PINEntr
4343
const [{ preventScreenCapture }, inlineMessages] = useServices([TOKENS.CONFIG, TOKENS.INLINE_ERRORS])
4444
usePreventScreenCapture(preventScreenCapture)
4545

46-
useEffect(() => {
47-
setInlineMessageField(undefined)
48-
}, [PIN])
49-
5046
const clearAlertModal = useCallback(() => {
5147
setAlertModalVisible(false)
5248
usage !== PINEntryUsage.ChangePIN && setAuthenticated(false)
@@ -161,6 +157,7 @@ const PINVerify: React.FC<PINVerifyProps> = ({ setAuthenticated, usage = PINEntr
161157
</ThemedText>
162158
<PINInput
163159
onPINChanged={async (userPinInput: string) => {
160+
setInlineMessageField(undefined)
164161
setPIN(userPinInput)
165162
if (userPinInput.length === minPINLength) {
166163
Keyboard.dismiss()

0 commit comments

Comments
 (0)