fix: don't 500 on strange version for revision API

Signed-off-by: Paul Spooren <mail@aparcar.org>

Author: aparcar

asu/routers/api.py

@@ -38,6 +38,12 @@ def api_v1_revision(
     version: str, target: str, subtarget: str, response: Response, request: Request
 ):
     branch_data = get_branch(version)
+    if "path" not in branch_data:
+        response.status_code = 400
+        return {
+            "detail": f"Unsupported version: {version}",
+            "status": 400,
+        }
     version_path = branch_data["path"].format(version=version)
     req = client_get(
         settings.upstream_url

tests/test_api.py

@@ -758,6 +758,15 @@ def test_api_revision(client):
     assert data["revision"] == "r24106-10cc5fcd00"
 
 
+def test_api_revision_bad_version(client):
+    response = client.get(
+        "/api/v1/revision/invalid-version/ath79/generic", follow_redirects=False
+    )
+    assert response.status_code == 400
+    data = response.json()
+    assert data["detail"] == "Unsupported version: invalid-version"
+
+
 def test_api_stats(client):
     response = client.get("/api/v1/stats", follow_redirects=False)
     assert response.status_code == 200