Merge pull request #53 from opera-adt/dev

v1.0.6

Author: cmarshak

CHANGELOG.md

@@ -6,6 +6,13 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
 and this project adheres to [PEP 440](https://www.python.org/dev/peps/pep-0440/)
 and uses [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
 
+## [1.0.6] - 2025-10-09
+
+### Added
+* Tests for MGRS tiles and burst geometries ensuring they overlap the antimeridian if and only if they are multipolygons.
+* Updated readme with information about these mgrs/burst geometries and the dateline.
+* Updated burst geometries using geopackage geometry from opera_adt/burst_db. See this issue: https://github.com/opera-adt/burst_db/issues/120 - some dateline geometries were cut off. The new geometries are larger and the table went from 24 MB to 37 MB. See this notebook: https://github.com/OPERA-Cal-Val/dist-s1-research/blob/dev/marshak/Zb_update_burst_table/Update%20Burst%20Geometries%20Using%20Geopackage.ipynb
+
 ## [1.0.5] - 2025-09-29
 
 ### Fixed

README.md

@@ -102,6 +102,15 @@ There are two category of tests: unit tests and integration tests. The former ca
 The integration tests that are the most time consuming are represented by the notebooks and are run only upon a release PR.
 These notebook tests are tagged with `notebooks` and can be excluded from the other tests with `pytest tests -m 'not notebooks'`.
 
+# Remarks about the Dateline/Dateline and Geometry
+
+The antimeridian (or dateline) is the line at the -180 longitude mark that global CRS tiles are wrapped by standard global reference systems.
+The geometries of the bursts and the MGRS tiles in this package are all in `epsg:4326` (standard lon/lat). 
+The geometries are all between -180 and 180 so those geometries that cross the antimeridian/dateline are generally wrapped.
+For MGRS tiles, the statement that a geometry overlaps the antimeridian occurs if and only if the geometry is a Polygon.
+The same is true for burst geometries.
+See `test_antimeridian_crossing` in [`tests/test_mgrs_burst_data.py`](tests/test_mgrs_burst_data.py).
+
 # Contributing
 
 We welcome contributions to this open-source package. To do so:

src/dist_s1_enumerator/data/jpl_burst_geo.parquet

@@ -1,5 +1,5 @@
 import pytest
-from shapely.geometry import Point
+from shapely.geometry import LineString, MultiPolygon, Point, Polygon
 
 from dist_s1_enumerator.exceptions import NoMGRSCoverage
 from dist_s1_enumerator.mgrs_burst_data import (
@@ -161,3 +161,20 @@ def test_all_bursts_in_lut() -> None:
     df_merged = df_bursts.merge(df_mgrs_lut, on='jpl_burst_id', indicator=True, how='left')
     burst_ids_not_in_lut = df_merged[df_merged['_merge'] == 'left_only'].jpl_burst_id.unique().tolist()
     assert len(burst_ids_not_in_lut) == 0
+
+
+def test_antimeridian_crossing() -> None:
+    df_mgrs = get_mgrs_table()
+    df_burst = get_burst_table()
+    antimeridian_0 = LineString(coordinates=((-180, 90), (-180, -90))).buffer(0.00000001)
+    antimeridian_1 = LineString(coordinates=((180, 90), (180, -90))).buffer(0.00000001)
+
+    for df in [df_mgrs, df_burst]:
+        for antimeridian in [antimeridian_0, antimeridian_1]:
+            ind_anti = df.geometry.intersects(antimeridian)
+            df_antimerid = df[ind_anti].reset_index(drop=True)
+            any_polygons = (df_antimerid.geometry.map(lambda geo: isinstance(geo, Polygon))).sum()
+            assert any_polygons == 0
+            df_antimerid_not = df[~ind_anti].reset_index(drop=True)
+            any_multis = (df_antimerid_not.geometry.map(lambda geo: isinstance(geo, MultiPolygon))).sum()
+            assert any_multis == 0