Handling some of the errors...poorly

Author: mereghost

app/models/project.rb

@@ -232,7 +232,7 @@ def project
   end
 
   def wiki
-    super.enabled ? super : nil
+    super&.enabled ? super : nil
   end
 
   def <=>(other)
@@ -243,7 +243,7 @@ def to_s
     name
   end
 
-  def workspace_label
+  def w
     case workspace_type
     when "program"
       I18n.t("label_program")

app/seeders/demo_data/version_builder.rb

@@ -72,6 +72,13 @@ def version
     def set_wiki!(version, config)
       return unless config
 
+      # FIXME: find a better solution to handle all things wiki seeding. - @mereghost
+
+      unless Wiki.exists?(project: version.project)
+        Wiki.create!(project: version.project, start_page: "Wiki")
+        version.project.reload
+      end
+
       version.wiki_page_title = config["title"]
 
       Journal::NotificationConfiguration.with false do

app/seeders/demo_data/wiki_seeder.rb

@@ -37,6 +37,8 @@ def initialize(project, project_data)
     end
 
     def seed_data!
+      create_project_wiki!
+
       text = project_data.lookup("wiki")
 
       return if text.blank?
@@ -55,6 +57,14 @@ def seed_data!
       end
     end
 
+    # FIXME: find a better solution to handle all things wiki seeding. - @mereghost
+    def create_project_wiki!
+      return project.reload.wiki if Wiki.exists?(project: @project)
+
+      Wiki.create!(project: @project, start_page: "Wiki")
+      @project.reload
+    end
+
     def create_wiki_page!(data, project:, parent: nil)
       WikiPage.create!(
         wiki: project.wiki,

app/seeders/standard.yml

@@ -215,7 +215,6 @@ projects:
       - work_package_tracking
       - news
       - gantt
-      - wiki
       - board_view
       - team_planner_view
       - meetings
@@ -538,7 +537,6 @@ projects:
     modules:
       - backlogs
       - news
-      - wiki
       - work_package_tracking
       - gantt
       - board_view

spec/controllers/activities_controller_spec.rb

@@ -104,8 +104,7 @@
 
     describe "with activated activity module" do
       let(:project) do
-        create(:project,
-               enabled_module_names: %w[activity wiki])
+        create(:project, enabled_module_names: %w[activity])
       end
 
       it "renders activity" do
@@ -117,8 +116,7 @@
 
     describe "without activated activity module" do
       let(:project) do
-        create(:project,
-               enabled_module_names: %w[wiki])
+        create(:project, enabled_module_names: [])
       end
 
       it "renders 403" do

spec/features/activities/wiki_activity_spec.rb

@@ -37,7 +37,7 @@
                                                     edit_wiki_pages
                                                     view_wiki_edits] })
   end
-  let(:project) { create(:project, enabled_module_names: %w[wiki activity]) }
+  let(:project) { create(:project, :with_internal_wiki, enabled_module_names: %w[activity]) }
   let(:wiki) { project.wiki }
   let(:editor) { Components::WysiwygEditor.new }
 
@@ -106,6 +106,6 @@
     visit project_activity_index_path(project)
 
     expect(page)
-      .to have_no_content("Wiki edits")
+      .to have_no_text("Wiki edits")
   end
 end

spec/features/external_link_capture_spec.rb

@@ -33,7 +33,7 @@
 RSpec.describe "External link capture", :js, :selenium do
   shared_let(:admin) { create(:admin) }
 
-  let(:project) { create(:project, enabled_module_names: %w[wiki]) }
+  let(:project) { create(:project, :with_internal_wiki) }
   let(:external_url) { "https://www.openproject.org/" }
   let!(:wiki_page) do
     create(:wiki_page,

spec/features/wiki/wiki_page_external_link_spec.rb

@@ -35,7 +35,7 @@
   current_user { admin }
 
   let(:external_url) { "https://www.openprojet.org/" }
-  let(:project) { create(:project, enabled_module_names: %w[wiki]) }
+  let(:project) { create(:project, :with_internal_wiki) }
   let!(:wiki_page) do
     create(:wiki_page,
            wiki: project.wiki,

spec/features/wysiwyg/bold_behavior_spec.rb

@@ -33,7 +33,7 @@
 RSpec.describe "Wysiwyg bold behavior", :js do
   current_user { create(:admin) }
 
-  let(:project) { create(:project, enabled_module_names: %w[wiki]) }
+  let(:project) { create(:project, :with_internal_wiki) }
   let(:editor) { Components::WysiwygEditor.new }
 
   def mac_osx?

spec/lib/open_project/text_formatting/markdown/child_pages_macro_spec.rb

@@ -40,18 +40,13 @@ def controller
   end
 
   shared_let(:project) do
-    create(:valid_project,
-           enabled_module_names: %w[wiki])
+    create(:valid_project, :with_internal_wiki)
   end
   shared_let(:member_project) do
-    create(:valid_project,
-           identifier: "member-project",
-           enabled_module_names: %w[wiki])
+    create(:valid_project, :with_internal_wiki, identifier: "member-project")
   end
   shared_let(:invisible_project) do
-    create(:valid_project,
-           identifier: "other-project",
-           enabled_module_names: %w[wiki])
+    create(:valid_project, :with_internal_wiki, identifier: "other-project")
   end
   shared_let(:user) do
     create(:user, member_with_permissions: { project => [:view_wiki_pages],