Map deprecated version macro to target versions

workPackageValue:X:version now renders all target versions of the work
package, single-line by default so legacy macros keep their inline
shape within existing content. Applies to both the web and export
render paths; the export formatter matches the one on the work package
list branch so either merges cleanly.

Author: akabiru

app/models/work_package/exports/formatters/target_versions.rb

@@ -0,0 +1,43 @@
+# frozen_string_literal: true
+
+#-- copyright
+# OpenProject is an open source project management software.
+# Copyright (C) the OpenProject GmbH
+#
+# This program is free software; you can redistribute it and/or
+# modify it under the terms of the GNU General Public License version 3.
+#
+# OpenProject is a fork of ChiliProject, which is a fork of Redmine. The copyright follows:
+# Copyright (C) 2006-2013 Jean-Philippe Lang
+# Copyright (C) 2010-2013 the ChiliProject Team
+#
+# This program is free software; you can redistribute it and/or
+# modify it under the terms of the GNU General Public License
+# as published by the Free Software Foundation; either version 2
+# of the License, or (at your option) any later version.
+#
+# This program is distributed in the hope that it will be useful,
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+# GNU General Public License for more details.
+#
+# You should have received a copy of the GNU General Public License
+# along with this program; if not, write to the Free Software
+# Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA  02110-1301, USA.
+#
+# See COPYRIGHT and LICENSE files for more details.
+#++
+
+module WorkPackage::Exports
+  module Formatters
+    class TargetVersions < ::Exports::Formatters::Default
+      def self.apply?(attribute, _export_format)
+        attribute.to_sym == :target_versions
+      end
+
+      def retrieve_value(object)
+        object.target_versions.map(&:name)
+      end
+    end
+  end
+end

app/models/work_package/exports/macros/attributes.rb

@@ -175,12 +175,25 @@ def self.resolve_value(obj, attribute, disabled_rich_text_fields, layout: nil)
         custom_field = find_custom_field(obj, attribute)
 
         attribute_name = convert_to_attribute_name(custom_field, attribute, obj)
+        attribute_name, layout = map_legacy_version(attribute_name, layout, obj)
         return " " unless can_view_attribute?(custom_field, obj, attribute_name)
 
         is_rich_text = custom_field&.formattable? || disabled_rich_text_fields.include?(attribute_name.to_sym)
         [format_attribute_value(attribute_name, obj.class, obj, is_rich_text, layout), is_rich_text]
       end
 
+      ##
+      # The deprecated version attribute renders the work package's target
+      # versions, on a single line by default so legacy macros keep their
+      # inline shape within existing content.
+      def self.map_legacy_version(attribute_name, layout, obj)
+        if obj.is_a?(WorkPackage) && attribute_name == "version"
+          ["target_versions", layout || "singleline"]
+        else
+          [attribute_name, layout]
+        end
+      end
+
       def self.can_view_attribute?(custom_field, obj, attribute_name)
         custom_field || allowed_to_view_attribute?(obj, attribute_name)
       end

config/initializers/export_formats.rb

@@ -50,6 +50,7 @@
       formatter WorkPackage, WorkPackage::Exports::Formatters::Id
       formatter WorkPackage, WorkPackage::Exports::Formatters::ProjectPhase
       formatter WorkPackage, WorkPackage::Exports::Formatters::SpentUnits
+      formatter WorkPackage, WorkPackage::Exports::Formatters::TargetVersions
 
       list Project, Projects::Exports::CSV
       list Project, Projects::Exports::PDF

frontend/src/app/shared/components/fields/macros/attribute-value-macro.component.ts

@@ -127,7 +127,15 @@ export class AttributeValueMacroComponent implements OnInit {
 
     const schema = await this.schemaCache.ensureLoaded(resource);
     const proxied = this.schemaCache.proxied(resource, schema);
-    const attribute = schema.attributeFromLocalizedName(attributeName) ?? this.dateAttribute(resource, proxied, attributeName);
+    let attribute = schema.attributeFromLocalizedName(attributeName) ?? this.dateAttribute(resource, proxied, attributeName);
+
+    // The deprecated version attribute renders the work package's target
+    // versions, single-line by default so legacy macros keep their inline shape.
+    if (resource._type === 'WorkPackage' && attribute === 'version') {
+      attribute = 'targetVersions';
+      this.layout = this.layout ?? 'singleline';
+    }
+
     const fieldSchema = proxied.ofProperty(attribute) as IFieldSchema|undefined;
 
     if (fieldSchema) {

spec/models/exports/pdf/common/macro_spec.rb

@@ -369,6 +369,41 @@
       end
     end
 
+    describe "with target versions" do
+      shared_let(:version_one) { create(:version, project:, name: "1.0") }
+      shared_let(:version_two) { create(:version, project:, name: "2.0") }
+
+      before do
+        create(:work_package_version, work_package:, version: version_one)
+        create(:work_package_version, work_package:, version: version_two)
+      end
+
+      describe "with targetVersions attribute" do
+        let(:markdown) { "workPackageValue:#{work_package.id}:targetVersions" }
+
+        it "outputs one version per line" do
+          # the association carries no order, so compare the lines as a set
+          expect(formatted.split("  \n")).to match_array(%w[1.0 2.0])
+        end
+      end
+
+      describe "with legacy version attribute" do
+        let(:markdown) { "workPackageValue:#{work_package.id}:version" }
+
+        it "outputs all target versions on a single line" do
+          expect(formatted.split(", ")).to match_array(%w[1.0 2.0])
+        end
+      end
+
+      describe "with legacy version attribute and multiline layout" do
+        let(:markdown) { "workPackageValue:#{work_package.id}:version:multiline" }
+
+        it "outputs one version per line" do
+          expect(formatted.split("  \n")).to match_array(%w[1.0 2.0])
+        end
+      end
+    end
+
     describe "with specific work package ID and attribute" do
       let(:markdown) { "workPackageValue:#{work_package.id}:subject" }
 

spec/models/work_package/exports/formatters/target_versions_spec.rb

@@ -0,0 +1,74 @@
+# frozen_string_literal: true
+
+#-- copyright
+# OpenProject is an open source project management software.
+# Copyright (C) the OpenProject GmbH
+#
+# This program is free software; you can redistribute it and/or
+# modify it under the terms of the GNU General Public License version 3.
+#
+# OpenProject is a fork of ChiliProject, which is a fork of Redmine. The copyright follows:
+# Copyright (C) 2006-2013 Jean-Philippe Lang
+# Copyright (C) 2010-2013 the ChiliProject Team
+#
+# This program is free software; you can redistribute it and/or
+# modify it under the terms of the GNU General Public License
+# as published by the Free Software Foundation; either version 2
+# of the License, or (at your option) any later version.
+#
+# This program is distributed in the hope that it will be useful,
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+# GNU General Public License for more details.
+#
+# You should have received a copy of the GNU General Public License
+# along with this program; if not, write to the Free Software
+# Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA  02110-1301, USA.
+#
+# See COPYRIGHT and LICENSE files for more details.
+#++
+
+require "spec_helper"
+
+RSpec.describe WorkPackage::Exports::Formatters::TargetVersions do
+  let(:formatter_instance) { described_class.new(:target_versions) }
+
+  describe ".apply?" do
+    it "returns true for :target_versions with any export format" do
+      expect(described_class.apply?(:target_versions, :pdf)).to be true
+      expect(described_class.apply?(:target_versions, :csv)).to be true
+      expect(described_class.apply?(:target_versions, :xls)).to be true
+    end
+
+    it "returns false for other attributes" do
+      expect(described_class.apply?(:version, :pdf)).to be false
+    end
+  end
+
+  describe "#format" do
+    let(:versions) { [build_stubbed(:version, name: "1.0"), build_stubbed(:version, name: "2.0")] }
+    let(:work_package) do
+      build_stubbed(:work_package) do |wp|
+        allow(wp)
+          .to receive(:target_versions)
+                .and_return(versions)
+      end
+    end
+
+    it "returns the joined version names" do
+      expect(formatter_instance.format(work_package)).to eq("1.0, 2.0")
+    end
+
+    it "honors the array_separator option" do
+      expect(formatter_instance.format(work_package, array_separator: "; ")).to eq("1.0; 2.0")
+    end
+
+    context "without target versions" do
+      let(:versions) { [] }
+
+      it "returns an empty string" do
+        expect(formatter_instance.format(work_package)).to eq("")
+      end
+    end
+  end
+end