Add support for PHPUnit >= 10

[Daimona]

The last supported version is PHPUnit 9, released in 2020. It would be nice to add support for newer PHPUnit version, starting from v10 (released 2023).

[oradwell]

thanks for creating this issue. I'll take a look

[oradwell]

it seems the coverage system was completely redesigned in PHPUnit 10. I couldn't get it to fail for invalid coverage tags. Can you check and let me know if coverage still fails on PHPUnit 10 for invalid coverage tags, please?

[Daimona]

I do see warnings for invalid covers, but they're under "PHPUnit Warnings", whereas in PHPUnit 9 they were under "Warnings". I think that might be a consequence of the PHPUnit 10 error handler rewrite.

Like in PHPUnit 9, the coverage report is generated anyway, but PHPUnit exits with code 1.

[Krinkle]

PHPUnit 10:

• Rename \PHPUnit\Util\Test::getLinesToBeCovered to \PHPUnit\Util\Test::linesToBeCovered. sebastianbergmann/phpunit@a631b29
• Refactor \PHPUnit\Util\Test::linesToBeCovered into PHPUnit\Metadata\CodeCoverageFacade::linesToBeCovered. sebastianbergmann/phpunit@7af6206
• Reorganize \PHPUnit\Metadata\CodeCoverageFacade into \PHPUnit\Metadata\Api\CodeCoverage. sebastianbergmann/phpunit@bff199b
• It looks like for PHPUnit 10, PHPUnit\Metadata\Api\CodeCoverage::linesToBeCovered is usable.

PHPUnit 11:

• Idem. (At glance, no relevant changes.)

PHPUnit 12:

• PHPUnit 12.0.0: Replace CodeCoverage::linesToBeCovered with CodeCoverage::coversTargets, which builds on top of the phpunit/php-code-coverage package.sebastianbergmann/phpunit@36a2aeb.
  • In particular, the "ThisDoesNotExist is not a valid target for code coverage" error message now comes from InvalidCodeCoverageTargetException thrown in SebastianBergmann\CodeCoverage\Test\Target\Mapper. sebastianbergmann/php-code-coverage@d6e6ecd
• PHPUnit 12.1.0: Remove unused PHPUnit\Framework\InvalidCoversTargetException and its parent PHPUnit\Framework\CodeCoverageException. sebastianbergmann/phpunit@a250e5a
• It looks like for PHPUnit 12, we can either try to use CodeCoverage::coversTargets, or use the php-code-coverage package directly.

If we try to use the php-code-coverage library, then it may be worth trying to use that in general. Note that the part of the library we need not added until php-code-coverage 12.0.0 (sebastianbergmann/php-code-coverage@d6e6ecd), which enforces a requirement of PHP 8.3, same as PHPUnit 12. So that means using the library for all versions only works if we're comfortable requiring PHP 8.3+. The earlier versions of the library could be used across all versions potentially, but those didn't yet have this logic.

So it might be easier to stick to calling the PHPUnit code with some conditionals to handle different versions, if for no other reason than to support installation via Composer, since we can't install conflicting versions of the same library alongside PHPUnit.

[oradwell]

Krinkle, Thanks for your analysis. I'd probably stick with calling PHPUnit code as you mentioned. I've managed to get it PHPUnit to fail. It seems the current test cases don't work because with PHPUnit 10, when there are no assertions, code coverage skips the tests. What version of PHPUnit are you guys using? Just to see if it's worth adding support for up to 11 for now or do we also need 12.

…

On Mon, 14 Jul 2025, 20:43 Timo Tijhof, ***@***.***> wrote: *Krinkle* left a comment (oradwell/covers-validator#44) <#44 (comment)> PHPUnit 10: - Rename \PHPUnit\Util\Test::getLinesToBeCovered to \PHPUnit\Util\Test::linesToBeCovered. ***@***.*** <sebastianbergmann/phpunit@a631b29> - Refactor \PHPUnit\Util\Test::linesToBeCovered into PHPUnit\Metadata\CodeCoverageFacade::linesToBeCovered. ***@***.*** <sebastianbergmann/phpunit@7af6206> - Reorganize \PHPUnit\Metadata\CodeCoverageFacade into \PHPUnit\Metadata\Api\CodeCoverage. ***@***.*** <sebastianbergmann/phpunit@bff199b> - It looks like for PHPUnit 10, PHPUnit\Metadata\Api\CodeCoverage::linesToBeCovered is usable. PHPUnit 11: - Idem. (At glance, no relevant changes.) PHPUnit 12: - PHPUnit 12.0.0: Replace CodeCoverage::linesToBeCovered with CodeCoverage::coversTargets, which builds on top of the phpunit/php-code-coverage ***@***.*** <sebastianbergmann/phpunit@36a2aeb>. - In particular, the "ThisDoesNotExist is not a valid target for code coverage" error message now comes from InvalidCodeCoverageTargetException thrown in SebastianBergmann\CodeCoverage\Test\Target\Mapper. ***@***.*** <sebastianbergmann/php-code-coverage@d6e6ecd> - PHPUnit 12.1.0: Remove unused PHPUnit\Framework\InvalidCoversTargetException and its parent PHPUnit\Framework\CodeCoverageException. sebastianbergmann/phpunit@ a250e5a <sebastianbergmann/phpunit@a250e5a> - It looks like for PHPUnit 12, we can either try to use CodeCoverage::coversTargets, or use the php-code-coverage package directly. If we try to use the php-code-coverage library, then it may be worth trying to use that in general. Note that the part of the library we need not added until php-code-coverage 12.0.0 ( ***@***.*** <sebastianbergmann/php-code-coverage@d6e6ecd>), which enforces a requirement of PHP 8.3, same as PHPUnit 12. So that means using the library for all versions only works if we're comfortable requiring PHP 8.3+. The earlier versions of the library could be used across all versions potentially, but those didn't yet have this logic. So it might be easier to stick to calling the PHPUnit code with some conditionals to handle different versions, if for no other reason than to support installation via Composer, since we can't install conflicting versions of the same library alongside PHPUnit. — Reply to this email directly, view it on GitHub <#44 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABGSDMG2BT6ZO7OVNPX6TUL3IQB5TAVCNFSM6AAAAAB7KOSDMSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTANZQG42TCMBXGQ> . You are receiving this because you commented.Message ID: ***@***.***>

[Krinkle]

@oradwell We're on PHPUnit 9, upgrading to 10.