Skip to content

Reconsider detected check colors in /hs inv (red 'true' is confusing) #42

@Th0rgal

Description

@Th0rgal

Problem

In the `/hs inv` UI, detected generic checks show `true` in red (high-risk) or yellow (low-risk), while the Fabric/Forge loader status shows `true` in green. This inconsistency confuses users — they expect green for `true` across the board.

Current color logic in `CommandsManager.java`:

  • Fabric/Forge loaders: `true` = green, `false` = red (lines 184-191)
  • Detected mods: `true` = red or yellow based on `isHighRiskCheck()` (lines 201-206)

The risk-based coloring makes sense from a security perspective (red = suspicious), but from a UI perspective it's confusing because the same word "true" appears in different colors depending on context.

Suggested approach

A few options:

Option A: Use consistent green for all "true" values
Simple and matches user expectations. Loses the risk-level visual signal.

Option B: Change the wording instead of the color
Instead of showing `ModName: true` in red, show something like:

  • `⚠ ModName` in red/yellow (detected, concerning)
  • `✓ ModName` in green (detected, benign)

This makes it clear that the color represents risk, not detection status.

Option C: Add a legend/header
Add a line like `Detected mods:` before the list to make it clear that everything listed below is detected, and the color indicates risk level.

Relevant files

  • `hackedserver-spigot/src/main/java/org/hackedserver/spigot/commands/CommandsManager.java` (lines 184-208, 223-235)

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions