Skip to content

Commit fc7a9cb

Browse files
authored
Merge pull request #22 from orcest-ai/claude/fix-build-isWeb-qNsCI
fix(orcide): resolve stale void references and type error from PR #18 merge
2 parents ea0f0b7 + 467bb5b commit fc7a9cb

4 files changed

Lines changed: 12 additions & 12 deletions

File tree

src/vs/code/electron-main/app.ts

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -126,12 +126,12 @@ import ErrorTelemetry from '../../platform/telemetry/electron-main/errorTelemetr
126126
// in theory this is not allowed
127127
// ignore the eslint errors below
128128
import { IMetricsService } from '../../workbench/contrib/orcide/common/metricsService.js';
129-
import { IOrcideUpdateService } from '../../workbench/contrib/orcide/common/voidUpdateService.js';
129+
import { IOrcideUpdateService } from '../../workbench/contrib/orcide/common/orcideUpdateService.js';
130130
import { MetricsMainService } from '../../workbench/contrib/orcide/electron-main/metricsMainService.js';
131-
import { VoidMainUpdateService } from '../../workbench/contrib/orcide/electron-main/voidUpdateMainService.js';
131+
import { OrcideMainUpdateService } from '../../workbench/contrib/orcide/electron-main/orcideUpdateMainService.js';
132132
import { LLMMessageChannel } from '../../workbench/contrib/orcide/electron-main/sendLLMMessageChannel.js';
133-
import { VoidSCMService } from '../../workbench/contrib/orcide/electron-main/voidSCMMainService.js';
134-
import { IOrcideSCMService } from '../../workbench/contrib/orcide/common/voidSCMTypes.js';
133+
import { OrcideSCMService } from '../../workbench/contrib/orcide/electron-main/orcideSCMMainService.js';
134+
import { IOrcideSCMService } from '../../workbench/contrib/orcide/common/orcideSCMTypes.js';
135135
import { MCPChannel } from '../../workbench/contrib/orcide/electron-main/mcpChannel.js';
136136
/**
137137
* The main VS Code application. There will only ever be one instance,
@@ -1103,8 +1103,8 @@ export class CodeApplication extends Disposable {
11031103

11041104
// Void main process services (required for services with a channel for comm between browser and electron-main (node))
11051105
services.set(IMetricsService, new SyncDescriptor(MetricsMainService, undefined, false));
1106-
services.set(IOrcideUpdateService, new SyncDescriptor(VoidMainUpdateService, undefined, false));
1107-
services.set(IOrcideSCMService, new SyncDescriptor(VoidSCMService, undefined, false));
1106+
services.set(IOrcideUpdateService, new SyncDescriptor(OrcideMainUpdateService, undefined, false));
1107+
services.set(IOrcideSCMService, new SyncDescriptor(OrcideSCMService, undefined, false));
11081108

11091109
// Default Extensions Profile Init
11101110
services.set(IExtensionsProfileScannerService, new SyncDescriptor(ExtensionsProfileScannerService, undefined, true));

src/vs/workbench/browser/parts/editor/editorGroupWatermark.ts

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@ import { splitRecentLabel } from '../../../../base/common/labels.js';
2525
import { IViewsService } from '../../../services/views/common/viewsService.js';
2626

2727
/* eslint-disable */ // Void
28-
import { VOID_CTRL_K_ACTION_ID, VOID_CTRL_L_ACTION_ID } from '../../../contrib/orcide/browser/actionIDs.js';
28+
import { ORCIDE_CTRL_K_ACTION_ID, ORCIDE_CTRL_L_ACTION_ID } from '../../../contrib/orcide/browser/actionIDs.js';
2929
import { VIEWLET_ID as REMOTE_EXPLORER_VIEWLET_ID } from '../../../contrib/remote/browser/remoteExplorer.js';
3030
/* eslint-enable */
3131

@@ -284,7 +284,7 @@ export class EditorGroupWatermark extends Disposable {
284284
else {
285285

286286
// show them Void keybindings
287-
const keys = this.keybindingService.lookupKeybinding(VOID_CTRL_L_ACTION_ID);
287+
const keys = this.keybindingService.lookupKeybinding(ORCIDE_CTRL_L_ACTION_ID);
288288
const dl = append(voidIconBox, $('dl'));
289289
const dt = append(dl, $('dt'));
290290
dt.textContent = 'Chat'
@@ -295,7 +295,7 @@ export class EditorGroupWatermark extends Disposable {
295295
this.currentDisposables.add(label);
296296

297297

298-
const keys2 = this.keybindingService.lookupKeybinding(VOID_CTRL_K_ACTION_ID);
298+
const keys2 = this.keybindingService.lookupKeybinding(ORCIDE_CTRL_K_ACTION_ID);
299299
const dl2 = append(voidIconBox, $('dl'));
300300
const dt2 = append(dl2, $('dt'));
301301
dt2.textContent = 'Quick Edit'

src/vs/workbench/contrib/files/browser/fileActions.contribution.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@ import { ThemeIcon } from '../../../../base/common/themables.js';
2727
import { IExplorerService } from './files.js';
2828
import { Codicon } from '../../../../base/common/codicons.js';
2929
import { Categories } from '../../../../platform/action/common/actionCommonCategories.js';
30-
import { VOID_OPEN_SETTINGS_ACTION_ID } from '../../void/browser/voidSettingsPane.js';
30+
import { ORCIDE_OPEN_SETTINGS_ACTION_ID } from '../../orcide/browser/orcideSettingsPane.js';
3131

3232
// Contribute Global Actions
3333

@@ -681,7 +681,7 @@ for (const menuId of [MenuId.EmptyEditorGroupContext, MenuId.EditorTabsBarContex
681681
MenuRegistry.appendMenuItem(MenuId.MenubarFileMenu, {
682682
group: '0_void',
683683
command: {
684-
id: VOID_OPEN_SETTINGS_ACTION_ID,
684+
id: ORCIDE_OPEN_SETTINGS_ACTION_ID,
685685
title: nls.localize({ key: 'openVoid', comment: ['&& denotes a mnemonic'] }, "&&Open Void Settings"),
686686
},
687687
order: 1

src/vs/workbench/contrib/orcide/browser/orcideSelectionHelperWidget.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -69,7 +69,7 @@ export class SelectionHelperContribution extends Disposable implements IEditorCo
6969
this._reactComponentDisposable = res;
7070
this._rerender = res.rerender;
7171

72-
this._register(this._reactComponentDisposable);
72+
this._register(res);
7373

7474

7575
});

0 commit comments

Comments
 (0)