Fixed bug where text files using CRLF line endings would fail to parse

orchetect · orchetect · commit ad8c3952a28a · 2025-07-27T01:13:19.000-07:00
diff --git a/Sources/TextFileKit/StringTableRepresentable.swift b/Sources/TextFileKit/StringTableRepresentable.swift
@@ -50,12 +50,14 @@ extension StringTableRepresentable {
             usedLossyConversion: &usedLossyConversion
         ),
               rawValue != 0,
-              let rawText = nsString as? String
+              var rawText = nsString as? String
         else {
             throw TextFile.ParserError.unrecognizedTextEncoding
         }
         let /*encoding*/ _ = String.Encoding(rawValue: rawValue) // TODO: not used
         
+        rawText = rawText.replacingOccurrences(of: "\r\n", with: "\n") // TODO: hacky line-ending conversion
+        
         self.init(rawText: rawText)
     }
 }

Original file line number	Diff line number	Diff line change
`@@ -50,12 +50,14 @@ extension StringTableRepresentable {`
`50`	`50`	`usedLossyConversion: &usedLossyConversion`
`51`	`51`	`),`
`52`	`52`	`rawValue != 0,`
`53`		`- let rawText = nsString as? String`
	`53`	`+ var rawText = nsString as? String`
`54`	`54`	`else {`
`55`	`55`	`throw TextFile.ParserError.unrecognizedTextEncoding`
`56`	`56`	`}`
`57`	`57`	`let /encoding/ _ = String.Encoding(rawValue: rawValue) // TODO: not used`
`58`	`58`
	`59`	`+ rawText = rawText.replacingOccurrences(of: "\r\n", with: "\n") // TODO: hacky line-ending conversion`
	`60`	`+`
`59`	`61`	`self.init(rawText: rawText)`
`60`	`62`	`}`
`61`	`63`	`}`