Attempting to upgrade sslyze formula but open questions

[ffloimair]

Output of brew config

HOMEBREW_VERSION: 4.4.19-92-g573e994
ORIGIN: https://github.com/Homebrew/brew
HEAD: 573e994f35f77274699300d854fd4c925e1e24d2
Last commit: 2 hours ago
Branch: master
Core tap HEAD: 4d2f53128210cfcfd3238d8c2d8c2157e9c01ad1
Core tap last commit: 58 minutes ago
Core tap JSON: 03 Feb 08:05 UTC
Core cask tap HEAD: 2a714e485770fe0a335e776fc9b1726d02591d9b
Core cask tap last commit: 3 hours ago
Core cask tap JSON: 03 Feb 08:05 UTC
HOMEBREW_PREFIX: /opt/homebrew
HOMEBREW_CASK_OPTS: []
HOMEBREW_EDITOR: nano
HOMEBREW_FORCE_BREWED_CURL: set
HOMEBREW_GITHUB_API_TOKEN: set
HOMEBREW_MAKE_JOBS: 12
HOMEBREW_NO_INSTALL_FROM_API: set
HOMEBREW_SORBET_RUNTIME: set
Homebrew Ruby: 3.3.7 => /opt/homebrew/Library/Homebrew/vendor/portable-ruby/3.3.7/bin/ruby
CPU: dodeca-core 64-bit arm_lobos
Clang: 16.0.0 build 1600
Git: 2.48.1 => /opt/homebrew/bin/git
Curl: 8.11.1 => /opt/homebrew/opt/curl/bin/curl
macOS: 15.3-arm64
CLT: 16.2.0.0.1.1733547573
Xcode: N/A
Rosetta 2: false

Output of brew doctor

Please note that these warnings are just used to help the Homebrew maintainers
with debugging if you file an issue. If everything you use Homebrew for is
working fine: please don't worry or file an issue; just ignore this. Thanks!

Warning: You have uncommitted modifications to Homebrew/homebrew-core.
If this is a surprise to you, then you should stash these modifications.
Stashing returns Homebrew to a pristine state but can be undone
should you later need to do so for some reason.
  cd /opt/homebrew/Library/Taps/homebrew/homebrew-core && git stash -u && git clean -d -f

Uncommitted files:
   M Formula/s/sslyze.rb

Description of issue

Hi!

I'm currently trying to update the sslyze formula. It was previously deprecated due to a dependency on openssl@1.1 which is no longer the case with version 6.0.0 or 6.1.0.

Keep in mind that this is my first attempt on a homebrew formula so please be easy on me.

So far everything is looking good to me except that the test step fails. This is due to a problem with the cryptography package used by sslyze. There exists a github issue for that: nabla-c0d3/sslyze#656

Would it be acceptable if I filed this formula with the test steps commented out for now?

Some other questions that I couldn't yet wrap my head around:

• sslyze 6.1.0 states that it no longer supports Intel-based Macs. It might work though but I can't test it. I have added a depends_on arch: :arm64 clause for now but I am not sure if that is correct

• what about the bottles section in the formula. Will this be auto-updated by a CI build once I push the commit and the PR gets accepted? I couldn't find anything in the docs about it.

I am thankful for any hints and tips.

As soon as I feel confident, that I have done everything as intended I will create a PR for it.

Best regards

Florian

[SMillerDev]

Would it be acceptable if I filed this formula with the test steps commented out for now?

Not really, we need to have a way to ensure it works.

sslyze 6.1.0 states that it no longer supports Intel-based Macs. It might work though but I can't test it. I have added a depends_on arch: :arm64 clause for now but I am not sure if that is correct

Does it not build from source on intel?

what about the bottles section in the formula. Will this be auto-updated by a CI build once I push the commit and the PR gets accepted? I couldn't find anything in the docs about it.

Yes it does: https://docs.brew.sh/Bottles#creation

[ffloimair]

Would it be acceptable if I filed this formula with the test steps commented out for now?

Not really, we need to have a way to ensure it works.

Well I could enhance the assertion with exit code 1 as the program definitely works it just spills out a warning about a negative certificate number from the cryptography package.

sslyze 6.1.0 states that it no longer supports Intel-based Macs. It might work though but I can't test it. I have added a depends_on arch: :arm64 clause for now but I am not sure if that is correct

Does it not build from source on intel?

I guess it does but I don't have a way to test it. But I don't see why it wouldn't as it does work on my Intel-based Linux machine.
The changelog for 6.1.0 just states that it no longer supports Intel-based Macs: https://github.com/nabla-c0d3/sslyze/releases/tag/6.1.0

what about the bottles section in the formula. Will this be auto-updated by a CI build once I push the commit and the PR gets accepted? I couldn't find anything in the docs about it.

Yes it does: https://docs.brew.sh/Bottles#creation

OK, great, thx! I didn't see the document about Bottles up to now.

[p-linnane]

You should wait to submit this until upstream fixes the issue that's causing the test failure. There is also no associated PR with the removal of Intel macOS support. Try opening an upstream issue asking for clarification, as I didn't see anything when I quickly skimmed the diff.