Replies: 1 comment
-
|
Hi,
Thanks for reminding me. My discipline was lacking :)
Mirek
…On Thu, Jan 22, 2026 at 3:20 PM Peter Ped Helcmanovsky < ***@***.***> wrote:
@mirek-fidler <https://github.com/mirek-fidler> just in case you are not
aware (or maybe you don't use this feature deliberately?), you can link
particular commit with github issue or pull request by adding it's ID to
commit message.
I see you often resolve issues (and pull requests) by pushing commit and
marking issue as "resolved", making it a bit unclear how/when it was
resolved (without manual search for relevant commit).
Example of current state:
issue: #354 <#354>
commit: 044bf82
<044bf82>
Suggestion:
if you would use commit summary like this:
- umk: help typo+ umk: help typo, fix #354
Then upon pushing the commit to github the issue would be auto-closed
based on the fix keyword and the commit reference would be traceable from
the Issue.
(like for example in this issue z00m128/sjasmplus#287
<z00m128/sjasmplus#287> near bottom is
reference to commit resolving it)
So, this way you cross-link issue with commit to make it easier to trace
it from both sides and you don't need to close issue manually on github web
as it will be auto-closed.
You can also reference issue from commit without closing it, just by
adding it's ID without keyword like "#354
<#354>" or "issue #354
<#354>", for example just
to reference some issue or when the commit is partial and not resolving the
issue completely.
Other keywords:
https://docs.github.com/en/issues/tracking-your-work-with-issues/using-issues/linking-a-pull-request-to-an-issue
I think this will save you tiny amount of time/effort in the long run AND
it will make easier for others to find out how the issue was fixed and when
the fix was merged to master branch.
—
Reply to this email directly, view it on GitHub
<#358>, or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AARH237633NTADDU3FQ22U34IDMCBAVCNFSM6AAAAACSROC2LSVHI2DSMVQWIX3LMV43ERDJONRXK43TNFXW4OZZGM3TMMBQGY>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Beta Was this translation helpful? Give feedback.
0 replies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Uh oh!
There was an error while loading. Please reload this page.
-
@mirek-fidler just in case you are not aware (or maybe you don't use this feature deliberately?), you can link particular commit with github issue or pull request by adding it's ID to commit message.
I see you often resolve issues (and pull requests) by pushing commit and marking issue as "resolved", making it a bit unclear how/when it was resolved (without manual search for relevant commit).
Example of current state:
issue: #354
commit: 044bf82
Suggestion:
if you would use commit summary like this:
Then upon pushing the commit to github the issue would be auto-closed based on the
fixkeyword and the commit reference would be traceable from the Issue.(like for example in this issue z00m128/sjasmplus#287 near bottom is reference to commit resolving it)
So, this way you cross-link issue with commit to make it easier to trace it from both sides and you don't need to close issue manually on github web as it will be auto-closed.
You can also reference issue from commit without closing it, just by adding it's ID without keyword like "#354" or "issue #354", for example just to reference some issue or when the commit is partial and not resolving the issue completely.
Other keywords: https://docs.github.com/en/issues/tracking-your-work-with-issues/using-issues/linking-a-pull-request-to-an-issue
I think this will save you tiny amount of time/effort in the long run AND it will make easier for others to find out how the issue was fixed and when the fix was merged to master branch.
Beta Was this translation helpful? Give feedback.
All reactions