Skip to content

Commit 27ef32b

Browse files
daniellicnerski1Daniel Licnerski Borges
andauthored
Revert provider API-key fallback (#978, #980) (#981)
* Revert "ci: make the provider-key resolver warn-only in the daily (#976) (#980)" This reverts commit ecb99b6. * Revert "feat(ci): provider API-key fallback — resolve a live key before the suite (#976) (#978)" This reverts commit 45a542a. --------- Co-authored-by: Daniel Licnerski Borges <daniellicnerski@MacBook-Pro-de-Daniel.local>
1 parent ecb99b6 commit 27ef32b

8 files changed

Lines changed: 94 additions & 451 deletions

File tree

.github/workflows/daily-stable.yml

Lines changed: 0 additions & 30 deletions
Original file line numberDiff line numberDiff line change
@@ -206,36 +206,6 @@ jobs:
206206
- name: Install dependencies
207207
run: npm ci
208208

209-
# Pick a LIVE key per provider before anything consumes one (#976). When a
210-
# provider's key dies, collect-models records it "inactive" and the 17
211-
# specs reading providers.json skip every target bound to it — silently,
212-
# because a skip never trips the daily-failure gate (24 specs lost that way
213-
# on 2026-07-27, #967). This probes <PROVIDER>_API_KEY, _2, _3... and
214-
# re-exports the first that answers under the canonical name, so the
215-
# Collect models step AND the sharded run below both inherit a validated
216-
# key. It runs here rather than inside collect-models because those are
217-
# separate steps: a fallback confined to collect-models would import the
218-
# backup into Langflow while this job's test step still held the dead
219-
# primary, and the first spec calling setupAnthropic would overwrite the
220-
# working credential with it.
221-
# WARN-ONLY, deliberately. An earlier revision failed the step when a
222-
# configured provider had no live key; on 2026-07-27 that killed all four
223-
# shards at the first step over a drained Anthropic account, blocking the
224-
# dozens of specs that never touch Anthropic. Picking a live key is worth
225-
# doing on its own — gating the run on it is not. A provider with no
226-
# usable candidate falls through to exactly the pre-existing behaviour:
227-
# collect-models records it inactive and its specs skip.
228-
- name: Resolve provider keys
229-
run: npx ts-node scripts/resolve-provider-keys.ts
230-
env:
231-
PROVIDER_KEYS_STRICT: "0"
232-
OPENAI_API_KEY: ${{ secrets.OPENAI_API_KEY }}
233-
OPENAI_API_KEY_2: ${{ secrets.OPENAI_API_KEY_2 }}
234-
ANTHROPIC_API_KEY: ${{ secrets.ANTHROPIC_API_KEY }}
235-
ANTHROPIC_API_KEY_2: ${{ secrets.ANTHROPIC_API_KEY_2 }}
236-
GOOGLE_API_KEY: ${{ secrets.GOOGLE_API_KEY }}
237-
GOOGLE_API_KEY_2: ${{ secrets.GOOGLE_API_KEY_2 }}
238-
239209
# Guard: the @playwright/test version (from npm) MUST equal the container
240210
# image tag, or the runner looks for a browser revision the image doesn't
241211
# ship and every test fails at launch with a cryptic error. Fail fast with

.github/workflows/pr-validation.yml

Lines changed: 0 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -191,22 +191,6 @@ jobs:
191191
# Skipped when no impacted spec needs provider model data (see detect-specs
192192
# → needs_models). Keeps a provider billing/quota outage from reddening a
193193
# PR whose specs never use that provider (#915/#910/#911 class).
194-
# Same key resolution the daily runs (#976) — pick a live candidate before
195-
# Collect models consumes one. WARN-ONLY here: this job must not go red
196-
# because an account was drained, which is the whole point of #952/#955.
197-
# Gated on needs_models for the same reason Collect models is.
198-
- name: Resolve provider keys
199-
if: needs.detect-specs.outputs.needs_models == 'true'
200-
run: npx ts-node scripts/resolve-provider-keys.ts
201-
env:
202-
PROVIDER_KEYS_STRICT: "0"
203-
OPENAI_API_KEY: ${{ secrets.OPENAI_API_KEY }}
204-
OPENAI_API_KEY_2: ${{ secrets.OPENAI_API_KEY_2 }}
205-
ANTHROPIC_API_KEY: ${{ secrets.ANTHROPIC_API_KEY }}
206-
ANTHROPIC_API_KEY_2: ${{ secrets.ANTHROPIC_API_KEY_2 }}
207-
GOOGLE_API_KEY: ${{ secrets.GOOGLE_API_KEY }}
208-
GOOGLE_API_KEY_2: ${{ secrets.GOOGLE_API_KEY_2 }}
209-
210194
- name: Collect models
211195
if: needs.detect-specs.outputs.needs_models == 'true'
212196
env:

package.json

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -19,8 +19,7 @@
1919
"coverage:summary": "ts-node scripts/coverage-summary.ts && ts-node scripts/stable-tests.ts",
2020
"impacted": "ts-node scripts/impacted-tests.ts",
2121
"validate:specs": "ts-node scripts/validate-spec-deps.ts",
22-
"check:nightly-delta": "ts-node scripts/check-nightly-delta.ts",
23-
"resolve:provider-keys": "ts-node scripts/resolve-provider-keys.ts"
22+
"check:nightly-delta": "ts-node scripts/check-nightly-delta.ts"
2423
},
2524
"dependencies": {
2625
"dotenv": "^16.4.5"

scripts/resolve-provider-keys.test.ts

Lines changed: 0 additions & 84 deletions
This file was deleted.

scripts/resolve-provider-keys.ts

Lines changed: 0 additions & 184 deletions
This file was deleted.

0 commit comments

Comments
 (0)