Commit c8dc37d
ci(migration): close the tracking issue only on the default branch (#1145)
`Close issue on success` fired on any green run, from any ref. So a
`workflow_dispatch` on a branch closed the issue that tracks a bug still present
on `main`.
Observed, not hypothesised: run #116 failed and opened #1143; run #117 was
dispatched on `fix/issue-1143-playground-reply-stream-race`, passed, and closed
#1143 at 17:29:23 — while the fix was unmerged and `main` still carried the racy
assertion. Nothing in the tracker recorded that the closure came from a branch.
What makes this worse than untidy: dispatching on a branch is the recommended
way to prove changes to this workflow — #1139, #1141 and #1143 could only be
proven that way. The practice that produces the best evidence was also the one
that silently wrote to the tracker.
Both jobs (`migration-test`, `migration-test-compose`) now guard the close with
`github.ref == 'refs/heads/main'`. Scheduled runs are unaffected: they run on the
default branch, verified against run 30530547302 (`event=schedule`,
`head_branch=main`).
The failure path is deliberately NOT scoped. A red branch run is worth filing —
that is exactly how #1143 was found. Instead both failure bodies now name the
ref and the event, so a reader can tell a branch experiment from a `main`
failure rather than assuming the latter.
Same family as #1120, #1141 and #1143: one signal read as proof of a different
claim.
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>1 parent 1906d09 commit c8dc37d
1 file changed
Lines changed: 19 additions & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
299 | 299 | | |
300 | 300 | | |
301 | 301 | | |
| 302 | + | |
| 303 | + | |
| 304 | + | |
| 305 | + | |
| 306 | + | |
| 307 | + | |
| 308 | + | |
| 309 | + | |
302 | 310 | | |
303 | | - | |
| 311 | + | |
304 | 312 | | |
305 | 313 | | |
306 | 314 | | |
| |||
332 | 340 | | |
333 | 341 | | |
334 | 342 | | |
| 343 | + | |
| 344 | + | |
| 345 | + | |
| 346 | + | |
335 | 347 | | |
336 | 348 | | |
337 | 349 | | |
| |||
355 | 367 | | |
356 | 368 | | |
357 | 369 | | |
| 370 | + | |
| 371 | + | |
358 | 372 | | |
359 | 373 | | |
360 | 374 | | |
| |||
743 | 757 | | |
744 | 758 | | |
745 | 759 | | |
| 760 | + | |
746 | 761 | | |
747 | | - | |
| 762 | + | |
748 | 763 | | |
749 | 764 | | |
750 | 765 | | |
| |||
790 | 805 | | |
791 | 806 | | |
792 | 807 | | |
| 808 | + | |
| 809 | + | |
793 | 810 | | |
794 | 811 | | |
795 | 812 | | |
| |||
0 commit comments