Add pagination to Terraform Cloud team adapter's Get request

Author: mike-gregory-ovo

adapters/terraformcloud/team/team.go

@@ -48,20 +48,45 @@ type Team struct {
 	Logger       *log.Logger
 }
 
+// getOrgIDsFromEmails takes a slice of emails, and returns a slice of Organisational Membership IDs.
+func (t *Team) getTeams(ctx context.Context) ([]string, error) {
+	pageNumber := 1
+	teams := make([]string, 0)
+
+	t.Logger.Printf("Fetching first page")
+
+	for {
+		tfeTeams, err := t.teams.List(ctx, t.organisation, &tfe.TeamListOptions{
+			ListOptions: tfe.ListOptions{PageNumber: pageNumber},
+		})
+		if err != nil {
+			return nil, fmt.Errorf("teams.list(%s) -> %w", t.organisation, err)
+		}
+
+		t.Logger.Printf("Fetched page %v in %v", tfeTeams.CurrentPage, tfeTeams.TotalPages)
+
+		for _, team := range tfeTeams.Items {
+			teams = append(teams, team.Name)
+			t.cache[team.Name] = team.ID
+		}
+
+		pageNumber = tfeTeams.NextPage
+
+		if tfeTeams.CurrentPage >= tfeTeams.TotalPages {
+			break
+		}
+	}
+
+	return teams, nil
+}
+
 // Get teams in a Terraform Cloud organisation.
 func (t *Team) Get(ctx context.Context) ([]string, error) {
 	t.Logger.Printf("Fetching teams in Terraform Cloud organisation %s", t.organisation)
 
-	tfeTeams, err := t.teams.List(ctx, t.organisation, &tfe.TeamListOptions{})
+	teams, err := t.getTeams(ctx)
 	if err != nil {
-		return nil, fmt.Errorf("terraformcloud.team.get.list -> %w", err)
-	}
-
-	teams := make([]string, 0, len(tfeTeams.Items))
-
-	for _, team := range tfeTeams.Items {
-		teams = append(teams, team.Name)
-		t.cache[team.Name] = team.ID
+		return nil, fmt.Errorf("terraformcloud.team.get.getteams -> %w", err)
 	}
 
 	t.Logger.Println("Fetched teams successfully")

adapters/terraformcloud/team/team_internal_test.go

@@ -6,7 +6,6 @@ import (
 
 	"github.com/hashicorp/go-tfe"
 	"github.com/stretchr/testify/assert"
-	"github.com/stretchr/testify/mock"
 
 	gosync "github.com/ovotech/go-sync"
 )
@@ -24,14 +23,32 @@ func TestTeam_Get(t *testing.T) {
 	adapter := New(&tfe.Client{}, "test")
 	adapter.teams = iTeamsClient
 
-	iTeamsClient.EXPECT().List(ctx, "test", mock.Anything).Return(&tfe.TeamList{
+	iTeamsClient.EXPECT().List(ctx, "test", &tfe.TeamListOptions{
+		ListOptions: tfe.ListOptions{PageNumber: 1},
+	}).Return(&tfe.TeamList{
+		Pagination: &tfe.Pagination{
+			CurrentPage: 1,
+			NextPage:    2,
+			TotalPages:  2,
+		},
 		Items: []*tfe.Team{{Name: "foo"}, {Name: "bar"}},
 	}, nil)
 
+	iTeamsClient.EXPECT().List(ctx, "test", &tfe.TeamListOptions{
+		ListOptions: tfe.ListOptions{PageNumber: 2},
+	}).Return(&tfe.TeamList{
+		Pagination: &tfe.Pagination{
+			CurrentPage: 2,
+			NextPage:    2,
+			TotalPages:  2,
+		},
+		Items: []*tfe.Team{{Name: "fizz"}, {Name: "buzz"}},
+	}, nil)
+
 	things, err := adapter.Get(ctx)
 
 	assert.NoError(t, err)
-	assert.ElementsMatch(t, things, []string{"foo", "bar"})
+	assert.ElementsMatch(t, things, []string{"foo", "bar", "fizz", "buzz"})
 }
 
 func TestTeam_Add(t *testing.T) {