[RELEASE] ios-app 11.5.0

[hosy]

Release a new version

Xcode version to work with:
Version 12.2 (12B45b)

TASKS:

Git & Code

• [GIT] Create branch release/[major].[minor].[patch] (freeze the code)
• [DEV] Update APP_SHORT_VERSION [major].[minor].[patch] in ownCloud.xcodeproj/project.pbxproj
• [TRFX] Update translations from transifex branch.
• [TRFX] Check for missing translations. Ping @cscherm
• [DIS] Update changelog
• [DEV] Update In-App Release Notes (changelog) in ownCloud/Release Notes/ReleaseNotes.plist
• [QA] Design Test plan
• [QA] Regression Test plan
• [DOC] Update user manual with the new functionalities
• [DOC] Update owncloud.org/download version numbers (notify #wordpress)
• [GIT] Merge branch release/[major].[minor].[patch] in master
• [GIT] Create tag and sign it [major].[minor].[patch]
• [GIT] Add the new release on GitHub ios-app

If it is required to update the iOS-SDK version:

• [GIT] Create branch library release/[major].[minor].[patch](freeze the code)
• [mail] inform #marketing about the new release.
• [DIS] Update README.md (version number, third party, supported versions of iOS, Xcode)
• [DIS] Update changelog
• [GIT] Merge branch release/[major].[minor].[patch] in master
• [GIT] Create tag and sign it [major].[minor].[patch]
• [GIT] Add the new release on GitHub ios-sdk

If it is required to update third party:

• [DIS] Update THIRD_PARTY.txt

App Store

• [DIS] App Store Connect: Create a new version following the [major].[minor].[patch]
• [DIS] App Store Connect: Trigger Fastlane screenshots generation and upload
• [DIS] Upload the binary to the App Store
• [DIS] App Store Connect: Trigger release (manually)
• [DIS] App Store Connect: Decide reset of iOS summary rating (Default: keep)
• [DIS] App Store Connect: Update description if necessary (coordinated with #marketing)
• [DIS] App Store Connect: Update changelogs
• [DIS] App Store Connect: Submit for review

QA

Test plan: https://github.com/owncloud/QA/blob/master/Mobile/iOS-app/Version%2011.5/Regression_11.5.md

BUGS & IMPROVEMENTS:

• (1) 301 Redirections are not correctly handled [RELEASE] ios-app 11.5.0 #886 (comment) [FIXED]
• (2) 302 redirection runs into infinite loop [RELEASE] ios-app 11.5.0 #886 (comment)
• (3) Glitch in token renewal [RELEASE] ios-app 11.5.0 #886 (comment) [FIXED]
• (4) (improvement) Select all in new picker [RELEASE] ios-app 11.5.0 #886 (comment) [WONT FIX]
• (5) Alignment of three-dot-button is lost [RELEASE] ios-app 11.5.0 #886 (comment) [WONT FIX]
• (6) Import from Share Sheet [RELEASE] ios-app 11.5.0 #886 (comment) [NOT REPRODUCIBLE]
• (7) After upgrading, sessions are lost [RELEASE] ios-app 11.5.0 #886 (comment) [FIXED]
• (8) Logging is disable after upgrading [RELEASE] ios-app 11.5.0 #886 (comment) [FIXED]

[jesmrec]

(1)

Bad behaviours in 301 redirection:

After server returns 301 with a correct location, app shows:

and it stops.

App 8bc2d1b1
SDK 5a70106
iPhoneXR v14.2

Logs:
ownCloud_3_Feb_2021_at_10_12_15.log.txt

[jesmrec]

(2)

With 302 redirection, the app runs into infinite loop

1. App checks /status.php -> server returns: Location: http://<url>/stable10/status.php
2. App checks http://<url>/stable10/status.php -> server returns 200
3. App checks again /status.php and goes to step 1.

App 8bc2d1b1
SDK 5a70106
iPhoneXR v14.2

Logs:
ownCloud_3_Feb_2021_at_10_13_51.log.txt

[felix-schwarz]

@jesmrec The log for (1) doesn't seem to contain any HTTP requests.

Re (2): please enable HTTP logging in the Logging settings, so the full requests are logged.

[jesmrec]

301 logs:
ownCloud_3_Feb_2021_at_10_12_15.log.txt

302 logs:
ownCloud_3_Feb_2021_at_10_13_51.log.txt

[jesmrec]

(3)

An small glitch when OAuth2 token expires.

The request to token endpoint is sent twice:

First one, everything works fine. Token is renewed and new refresh token is granted
Second one uses the same refresh token as the first one. That token is not valid anymore, since first request granted a new one, so it returns 400 causing this visual effect:

But, session goes on with the token granted in first request

App 8bc2d1b1
SDK 5a70106
iPhoneXR v14.2

Logs:
ownCloud_3_Feb_2021_at_10_27_52.log.txt

[jesmrec]

(4) (improvement)

Option Select All is missed with the new Photo/Album picker. It'd be interesting to check whether exists any choice to recover it somehow.

Btw, it is also missing the RAW indicator. Any way to include it?

[jesmrec]

(5) [WONT FIX]

Fix developed here: #870 (comment)

is missed somewhere:

App 8bc2d1b1
SDK 5a70106
iPhoneXR v14.2

[hosy]

@jesmrec (5) this cannot be fixed, because if sort key = name and the file list is longer than the visible area, the index bar will be shown on the right side and the cell content will get a right inset.
If you change the sort key or the file list is not so long, everything is fine.

[jesmrec]

thanks for the explanation, got it.

[felix-schwarz]

@jesmrec (1) and (2) should be fixed.

Regarding (2), the problem was this:

• 302 is not an actually supported way to redirect to a different OC root.
• instead a 302 response triggers the Connection Validator, which then got caught up in the responses.

The Connection Validator now detects that infinite loop and breaks out of it after 3 attempts. It then falls back to delivering the 302 response "as-is", like the Connection Validator did not exist.

That could mean that the 302 could end up working - but only as a lucky byproduct, not because it is supported.

I changed connection setup to only accept 301 redirects to other root folders, so that if it receives a 302 (or any other redirection status code) response, it will fail with an error.

[felix-schwarz]

@jesmrec Would love to look at (3), but the log file didn't complete uploading in your comment.

[jesmrec]

@jesmrec Would love to look at (3), but the log file didn't complete uploading in your comment.

this is the log of (3), now completely uploaded

ownCloud_3_Feb_2021_at_10_27_52.log.txt

[jesmrec]

About (1) and (2), with commit 523a404 :

(1) -> with the redirected ocis.owncloud.works, it works fine. I have a server with redirection 301 that points to a different folder (like the 302 in the report (2) ). Is this supported? The request flow is a little strange, from my pov:

At the end, this error happens:

These are the logs:

ownCloud_4_Feb_2021_at_09_41_10.log.txt

(2) -> Regarding 302, the test server i have contains a redirection. Any other way/server to test correctly with 302?