test: cover budget overview with a deleted agent scope

Deletes the agent a policy points at, then reads the overview. Fails against the
unfixed resolver, which threw notFound and took out the whole view rather than
degrading the one affected row.

Author: markkuhr

server/src/__tests__/budgets-service.test.ts

@@ -1,4 +1,5 @@
 import { randomUUID } from "node:crypto";
+import { eq } from "drizzle-orm";
 import { afterAll, afterEach, beforeAll, beforeEach, describe, expect, it, vi } from "vitest";
 import {
   agents,
@@ -637,4 +638,39 @@ describeEmbeddedPostgres("budgetService release gate enforcement", () => {
     });
     expect(overviewAfterResume.activeIncidents).toHaveLength(0);
   });
+
+  it("keeps the overview readable after the agent a policy points at is deleted", async () => {
+    const { companyId, agentId } = await createBudgetFixture();
+    const service = budgetService(db, { cancelWorkForScope: vi.fn().mockResolvedValue(undefined) });
+    await db.insert(budgetPolicies).values({
+      companyId,
+      scopeType: "agent",
+      scopeId: agentId,
+      metric: "billed_cents",
+      windowKind: "lifetime",
+      amount: 500,
+      warnPercent: 80,
+      hardStopEnabled: true,
+      notifyEnabled: false,
+      isActive: true,
+    });
+
+    // scopeId is a soft reference with no foreign key, so deleting the agent
+    // leaves the policy pointing at a row that is gone.
+    await db.delete(agents).where(eq(agents.id, agentId));
+
+    // Previously this threw notFound. The overview resolves every scope in one
+    // pass, so one deleted agent took out the whole view instead of one row.
+    const overview = await service.overview(companyId);
+
+    expect(overview.policies).toHaveLength(1);
+    expect(overview.policies[0]).toMatchObject({
+      scopeType: "agent",
+      scopeId: agentId,
+      amount: 500,
+      paused: false,
+    });
+    expect(overview.policies[0]?.scopeName).toContain("deleted");
+  });
+
 });