smoldot ExternalOffchainIndexSet doesn't set offchain storage.

[Wsteth]

smoldot version: 0.19.3

Hi there,
I use chopsticks to test some offchain things.
the runtime code use offchain_index.set, but it doesn't work.
I found the problem occurs here.
https://github.com/smol-dot/smoldot/blob/37482d9a635a17f9e6a77aa245b4684b2f72e750/lib/src/executor/runtime_call.rs#L1750-L1759

It seems there is nothing done with add pending_storage_changes, and when I remove pending_storage_changes, I can get the storage value.

[tomaka]

Hi,

I haven't touched this code is several years, but I believe that this is intentional.
The "offchain index" API is actually unrelated to the "offchain storage" API. They're two separate things.
I don't remember, however, what the differences are, and I can't really find information on the Internet, but since you're presumably working on this you might be more familiar with it.

[Wsteth]

Hi,

I haven't touched this code is several years, but I believe that this is intentional. The "offchain index" API is actually unrelated to the "offchain storage" API. They're two separate things. I don't remember, however, what the differences are, and I can't really find information on the Internet, but since you're presumably working on this you might be more familiar with it.

Hi sir, I've create a PR #2119 to fix this problem, please check and review it.