Skip to content

fixed two bugs of recent issue#157

Closed
FoggyDawn wants to merge 3 commits into
pascal-lab:masterfrom
FoggyDawn:master
Closed

fixed two bugs of recent issue#157
FoggyDawn wants to merge 3 commits into
pascal-lab:masterfrom
FoggyDawn:master

Conversation

@FoggyDawn

Copy link
Copy Markdown
Contributor

on issue 155 and 156
tested on XCorpus dataset
AnnotationModel bug illustrative example
emma-2.0.5312
CHA bug illustrative example
aoi-2.8.1

@github-actions

github-actions Bot commented May 23, 2025

Copy link
Copy Markdown

All contributors have signed the CLA ✍️ ✅
Posted by the CLA Assistant Lite bot.

@FoggyDawn

Copy link
Copy Markdown
Contributor Author

I have read the CLA Document and I hereby sign the CLA

github-actions Bot added a commit that referenced this pull request May 23, 2025
@zhangt2333

zhangt2333 commented May 23, 2025

Copy link
Copy Markdown
Member

Hi, @FoggyDawn

Thanks for the contribution! To help with review and maintenance, could you please:

  1. Split into smaller PRs - This covers quite a lot of changes. Smaller, focused PRs are easier to review and merge.

  2. Add unit tests if possible - Please include tests that demonstrate the original bug/issue and verify your fix resolves it.

  3. Use minimal changes if possible - If this is a bug fix, let's use the smallest possible fix.

Happy to discuss the approach or help prioritize which parts to tackle first.

Thanks!

@FoggyDawn

Copy link
Copy Markdown
Contributor Author

Hi, @FoggyDawn

Thanks for the contribution! To help with review and maintenance, could you please:

  1. Split into smaller PRs - This covers quite a lot of changes. Smaller, focused PRs are easier to review and merge.
  2. Add unit tests if possible - Please include tests that demonstrate the original bug/issue and verify your fix resolves it.
  3. Use minimal changes if possible - If this is a bug fix, let's use the smallest possible fix.

Happy to discuss the approach or help prioritize which parts to tackle first.

Thanks!

sorry, I didn't notice that further commits in my fork would influence pull request. I will try to figure that out and clean commits for my own project

@FoggyDawn

Copy link
Copy Markdown
Contributor Author

I will open two new pull request later, with only a few changes involving only one file each.

@FoggyDawn

Copy link
Copy Markdown
Contributor Author

new pull request updated

@FoggyDawn FoggyDawn closed this May 26, 2025
@github-actions github-actions Bot locked and limited conversation to collaborators May 26, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants