Use Rspack naming for WebAssembly assets

Author: pastelsky

src/config/makeRspackConfig.ts

@@ -198,6 +198,7 @@ export default function makeRspackConfig({
     },
     output: {
       filename: '[name].bundle.js',
+      webassemblyModuleFilename: '[hash].bundle.wasm',
       path: outputPath,
     },
     externals: ({ request }, callback) =>

src/utils/build.utils.ts

@@ -332,9 +332,16 @@ const BuildUtils = {
       throwIfAborted(options.signal)
       const gzip = gzipSync(bundleContents, {}).length
       const matches = asset.name.match(/(.+?)\.bundle\.(.+)$/)
-      const parsedAssetName = path.parse(asset.name)
-      const entryName = matches?.[1] || parsedAssetName.name
-      const extension = matches?.[2] || parsedAssetName.ext.slice(1) || 'asset'
+
+      if (!matches) {
+        throw new UnexpectedBuildError(
+          'Found an asset without the `.bundle` suffix. ' +
+            'A loader customization might be needed to recognize this asset type' +
+            asset.name,
+        )
+      }
+
+      const [, entryName, extension] = matches
 
       return {
         name: entryName,

tests/fast/build.utils.test.ts

@@ -1,5 +1,4 @@
 import { afterEach, describe, expect, test, vi } from 'vitest'
-import fs from 'node:fs'
 import { BuildCancelledError } from '../../src/errors/CustomError'
 
 const mockRspack = vi.fn()
@@ -16,8 +15,6 @@ vi.mock('../../src/config/makeRspackConfig.js', () => ({
 vi.mock('../../src/utils/telemetry.utils.js', () => ({
   default: {
     compilePackage: mockCompilePackage,
-    parseWebpackStats: vi.fn(),
-    assetsGZIPParseTime: vi.fn(),
   },
 }))
 
@@ -216,32 +213,4 @@ describe('BuildUtils.buildPackage', () => {
       missingModules: ['missing-package'],
     })
   })
-
-  test('preserves emitted assets that do not use the bundle filename pattern', async () => {
-    const stats = {
-      compilation: { errors: [] },
-      toJson: () => ({
-        assets: [
-          { name: 'main.bundle.js', size: 100, chunkNames: ['main'] },
-          { name: 'assets/module.wasm', size: 50, chunkNames: [] },
-        ],
-      }),
-    }
-
-    vi.spyOn(BuildUtils, 'createEntryPoint').mockReturnValue('/tmp/index.js')
-    vi.spyOn(BuildUtils, 'compilePackage').mockResolvedValue({
-      error: null,
-      stats: stats as any,
-    })
-    vi.spyOn(fs.promises, 'readFile').mockResolvedValue(
-      Buffer.from('asset contents'),
-    )
-
-    await expect(BuildUtils.buildPackage(buildArgs)).resolves.toMatchObject({
-      assets: [
-        { name: 'main', type: 'js', size: 100 },
-        { name: 'module', type: 'wasm', size: 50 },
-      ],
-    })
-  })
 })

tests/fast/makeRspackConfig.test.ts

@@ -0,0 +1,19 @@
+import { describe, expect, test } from 'vitest'
+
+import makeRspackConfig from '../../src/config/makeRspackConfig.js'
+
+describe('makeRspackConfig', () => {
+  test('uses the bundle filename convention for WebAssembly modules', () => {
+    const config = makeRspackConfig({
+      packageName: 'fixture',
+      entry: '/tmp/index.js',
+      externals: {
+        externalPackages: [],
+        externalBuiltIns: [],
+      },
+      outputPath: '/tmp/output',
+    })
+
+    expect(config.output?.webassemblyModuleFilename).toBe('[hash].bundle.wasm')
+  })
+})