Feat bump aiobmsble to 0.24.0 (#721)

* bump aiobmsble to 0.23.0

* code optimization

* add pylint to CI/CD

* Update Pylint step to continue on error

Allow Pylint to continue on error during linting.

* Update README with RSSI sensor FAQ

Added FAQ entry about RSSI sensor updates and availability.

* fix _attr_pack() signature

* Update README.md

* remove ECO-WORTHY limitation

* Add detection for Sungoldpower batteries (#723)

* bump aiobmsble

* Update manifest.json

* bump aiobmsble to 0.23.0 (#704)

* Update README with NEEY BMS v2

Added NEEY BMS v2 to the list of supported devices.

* Change problem code type (#707)

* change problem code type

* fix test according to new problem code type

* fix test

* Update README.md

* fix merged aiobmsble branch

* bump aiobmsble to 0.24.0

* update HA to 2026.6.0

closes #713, closes #711

* remove advanced options from tests

* fix TempSensor in tests

* fix BLEDevice path

* fix test errors

* minimize test requirements

* update python/ruff version

* requirements to avoid warnings

* patch fixture issue

* mitigate lingering timers

* fix flaky tests

* update pre-commit

* update mypy settings

* fix still flaky test

* update manifest

* fix race condition

Author: patman15

.github/workflows/fuzzing.yaml

@@ -18,7 +18,7 @@ jobs:
         - name: "Set up Python"
           uses: actions/setup-python@main
           with:
-            python-version: "3.13"
+            python-version: "3.14"
             cache: "pip"
 
         - name: Install dependencies

.github/workflows/hassfest.yaml

@@ -5,6 +5,8 @@ permissions:
 
 on:
   push:
+    branches:
+      - main    
   pull_request:
   workflow_dispatch:
   schedule:

.github/workflows/lint.yml

@@ -5,6 +5,8 @@ permissions:
 
 on:
   push:
+    branches:
+      - main    
   pull_request:
   workflow_dispatch:
   schedule:
@@ -21,14 +23,18 @@ jobs:
         - name: "Set up Python"
           uses: actions/setup-python@main
           with:
-            python-version: "3.13"
+            python-version: "3.14"
             cache: "pip"
 
         - name: "Install requirements"
           run: python3 -m pip install -r requirements_test.txt
 
         - name: "Run Ruff"
           run: python3 -m ruff check .
+
+        - name: "Run Pylint"
+          continue-on-error: true
+          run: python3 -m pylint .
 
         - name: "Run MyPy"
           run: python3 -m mypy .

.github/workflows/tests.yaml

@@ -2,6 +2,8 @@ name: Run tests for integrations
 
 on:
   push:
+    branches:
+      - main    
   pull_request:
   workflow_dispatch:
   schedule:
@@ -20,7 +22,7 @@ jobs:
         - name: "Set up Python"
           uses: actions/setup-python@main
           with:
-            python-version: "3.13"
+            python-version: "3.14"
             cache: "pip"
 
         - name: Install dependencies

.gitignore

@@ -162,4 +162,5 @@ cython_debug/
 TODO.md
 
 # macOS
-.DS_Store
+.DS_Store
+scripts/create_bump_aiobmsble_branch.py

.pre-commit-config.yaml

@@ -1,12 +1,12 @@
 repos:
   - repo: https://github.com/astral-sh/ruff-pre-commit
-    rev: v0.11.0  # ruff version, needs to match installed version
+    rev: v0.15.20  # ruff version, needs to match installed version
     hooks:
       - id: ruff
   # - repo: https://github.com/pre-commit/mirrors-mypy
-  #   rev: v1.17.0  # Use the latest stable version of mypy
+  #   rev: v2.1.0  # Use the latest stable version of mypy
   #   hooks:
   #     - id: mypy
-  #       additional_dependencies: [homeassistant==2025.7.0] # takes long thus mypy disabled here
+  #       additional_dependencies: [homeassistant==2026.6.0] # takes long thus mypy disabled here
   #       args: ["--allow-subclassing-any"]  # avoid HA dependency installation
   #       # args: [--ignore-missing-imports]  # Optional: customize your mypy flags

README.md

@@ -52,13 +52,15 @@ This integration allows to monitor Bluetooth Low Energy (BLE) battery management
     - DCHOUSE batteries (show up as `DCHOUSE`…)
 - Ective, Startcraft, Topband batteries (show up as `$PFLAC`…, `NWJ20`…, `ZM20`…)
 - EG4 LL BMS
+    - Sungold batteries
 - Eleksol batteries
 - Felicity ESS (show up as `F10`…) and FLB batteries (show up as `F07`…)
 - Gobel Power BMS (show up as `BMS-`…)
 - HumsiENK Smart BMS (show up as `HS`…)
+    - ECO-WORTHY (show up as `ECO....`)
 - JBD BMS, Jiabaida, Xiaoxiang (show up as `JBD-`…)
     - accurat batteries, Aolithium batteries
-    - BasenGreen, Bulltron, CHINS, DCHOUSE, ECO-WORTHY, Epoch batteries
+    - BasenGreen, Bulltron, CHINS, Cloud Energy, DCHOUSE, ECO-WORTHY, Epoch batteries
     - Eleksol, Elfhub, Fritz Berger, JavaEnegy, LANPWR, Liontron, Lossigy, Norström, OGRPHY, Perfektium, Ultimatron batteries
     - SBL batteries (show up as `SBL-`…), Supervolt v3 batteries (show up as `SX1`…), Vatrer batteries
 - JK BMS, Jikong, (HW version ≥ 6 required)
@@ -164,10 +166,6 @@ This integration follows standard integration removal. No extra steps are requir
 
 ### Known Issues
 
-<details><summary>ECO-WORTHY batteries "<code>ECOxxxx</code>"</summary>
-ECO-WORTHY batteries that show up as <code>ECOxxxx</code> use classic Bluetooth and do not support Bluetooth Low Energy (BLE). Thus, they unfortunately cannot be integrated.
-The advertisement contains <code>{"name":"ECOxxxx","service_uuids":["0000ff00-0000-1000-8000-00805f9b34fb","00000001-0000-1000-8000-00805f9b34fb"]</code>
-</details>
 <details><summary>Elektronicx, Lithtech batteries</summary>
 Bluetooth is turned off, when there is no current. Thus, device will get unavailable / cannot be added.
 </details>
@@ -261,6 +259,9 @@ Then go to the [energy dashboard configuration](https://my.home-assistant.io/red
 ### My sensors show unknown/unavailable at startup!
 The polling interval is 30 seconds. So at startup it takes a few minutes to detect the battery and query the sensors. Then data will be available.
 
+### Why is the RSSI sensor not updated or is unavailable?
+The `RSSI` value is only measured by Home Assistant when a device is not connected. Thus, you will see updates only in case a connection is lost or after a restart. The integration by default tries to maintain a permanent connection to improve data availability and avoid constant reconnect not appreciated by some BMSs.
+
 ### Can I set a custom polling interval?
 Yes, but I strongly discourage that for stability reasons. If you still want to do so, please see the default way to define a [custom interval][custint-url] by Home Assistant. Note that Bluetooth discoveries can take up to a minute in worst case. Thus, please expect side effects, when changing the default of 30 seconds!
 
@@ -336,7 +337,7 @@ all [contributors of aiobmsble](https://github.com/patman15/aiobmsble?tab=readme
 [license-shield]: https://img.shields.io/github/license/patman15/BMS_BLE-HA?style=for-the-badge&color=orange&cacheSeconds=86400
 [releases-shield]: https://img.shields.io/github/release/patman15/BMS_BLE-HA.svg?style=for-the-badge&cacheSeconds=14400
 [releases]: https://github.com//patman15/BMS_BLE-HA/releases
-[effort-shield]: https://img.shields.io/badge/Effort%20spent-1016_hours-gold?style=for-the-badge&cacheSeconds=86400
+[effort-shield]: https://img.shields.io/badge/Effort%20spent-1073_hours-gold?style=for-the-badge&cacheSeconds=86400
 [install-shield]: https://img.shields.io/badge/dynamic/json?style=for-the-badge&color=green&label=HACS&suffix=%20Installs&cacheSeconds=15600&url=https://analytics.home-assistant.io/custom_integrations.json&query=$.bms_ble.total&cacheSeconds=14400
 [btproxy-url]: https://esphome.io/components/bluetooth_proxy
 [custint-url]: https://www.home-assistant.io/common-tasks/general/#defining-a-custom-polling-interval

custom_components/bms_ble/binary_sensor.py

@@ -1,6 +1,7 @@
 """Support for BMS_BLE binary sensors."""
 
 from collections.abc import Callable
+from typing import override
 
 from aiobmsble import BMSMode, BMSSample
 
@@ -137,15 +138,17 @@ def __init__(
         self._attr_unique_id = f"{DOMAIN}-{unique_id}-{descr.key}"
         self._attr_device_info = bms.device_info
         self._attr_has_entity_name = True
-        self.entity_description: BmsBinaryEntityDescription = descr
+        self.entity_description = descr
         super().__init__(bms)
 
     @property
+    @override
     def is_on(self) -> bool | None:
         """Handle updated data from the coordinator."""
         return bool(self.coordinator.data.get(self.entity_description.key))
 
     @property
+    @override
     def extra_state_attributes(self) -> dict[str, int | str] | None:
         """Return entity specific state attributes, e.g. cell voltages."""
         return (

custom_components/bms_ble/config_flow.py

@@ -1,7 +1,7 @@
 """Config flow for BLE Battery Management System integration."""
 
 from dataclasses import dataclass
-from typing import Any, Final
+from typing import Any, Final, override
 
 from aiobmsble.basebms import BaseBMS
 from aiobmsble.utils import bms_cls, bms_identify
@@ -83,15 +83,16 @@ async def _async_device_supported(
         )
         return str(bms_class.get_bms_module())
 
+    @override
     async def async_step_bluetooth(
         self, discovery_info: BluetoothServiceInfoBleak
     ) -> ConfigFlowResult:
         """Handle a flow initialized by Bluetooth discovery."""
         LOGGER.debug("Bluetooth device detected: %s", discovery_info)
 
         address: Final = discovery_info.address
-        await self.async_set_unique_id(address)
-        self._abort_if_unique_id_configured()
+        if await self.async_set_unique_id(address, raise_on_progress=False):
+            return self.async_abort(reason="already_configured")
 
         if not (bms_module := await self._async_device_supported(discovery_info)):
             return self.async_abort(reason="not_supported")
@@ -114,7 +115,11 @@ async def async_step_bluetooth_confirm(
         LOGGER.debug("confirm step for %s", self._disc_dev.name)
 
         if user_input is not None:
-            self._abort_if_unique_id_configured()
+            if await self.async_set_unique_id(
+                self._disc_dev.discovery_info.address, raise_on_progress=False
+            ):
+                return self.async_abort(reason="already_configured")
+
             return self.async_create_entry(
                 title=self._disc_dev.name,
                 data={"type": self._disc_dev.type},
@@ -127,6 +132,7 @@ async def async_step_bluetooth_confirm(
             description_placeholders=self.context.get("title_placeholders"),
         )
 
+    @override
     async def async_step_user(
         self, user_input: dict[str, Any] | None = None
     ) -> ConfigFlowResult:
@@ -138,8 +144,8 @@ async def async_step_user(
 
         if user_input is not None:
             address = str(user_input[CONF_ADDRESS])
-            await self.async_set_unique_id(address, raise_on_progress=False)
-            self._abort_if_unique_id_configured()
+            if await self.async_set_unique_id(address, raise_on_progress=False):
+                return self.async_abort(reason="already_configured")
             self._disc_dev = self._disc_devs[address]
 
             return self.async_create_entry(
@@ -186,6 +192,7 @@ async def async_step_user(
 
     @staticmethod
     @callback
+    @override
     def async_get_options_flow(
         config_entry: ConfigEntry,
     ) -> OptionsFlowWithReload:

custom_components/bms_ble/coordinator.py

@@ -2,8 +2,9 @@
 
 from collections import deque
 from datetime import timedelta
+from itertools import islice
 from time import monotonic
-from typing import Final
+from typing import Final, override
 
 from aiobmsble import BMSSample
 from aiobmsble.basebms import BaseBMS
@@ -81,6 +82,7 @@ def link_quality(self) -> int:
 
         return self._link_q.count(True) * 100 // len(self._link_q)
 
+    @override
     async def async_shutdown(self) -> None:
         """Shutdown coordinator and any connection."""
         LOGGER.debug("Shutting down BMS (%s)", self.name)
@@ -93,7 +95,7 @@ def _device_stale(self) -> bool:
         elif (
             not self._stale
             and self.link_quality <= 10
-            and list(self._link_q)[-10:] == [False] * 10
+            and list(islice(reversed(self._link_q), 10)) == [False] * 10
         ):
             rssi: Final = self.rssi
             LOGGER.error(
@@ -107,6 +109,7 @@ def _device_stale(self) -> bool:
 
         return self._stale
 
+    @override
     async def _async_setup(self) -> None:
         bms_info: Final = await self._device.device_info()
         self.device_info.update(
@@ -122,6 +125,7 @@ async def _async_setup(self) -> None:
             )
         )
 
+    @override
     async def _async_update_data(self) -> BMSSample:
         """Return the latest data from the device."""