#5364 Fixed triggering inline cell editor with polish characters.

Author: pawelsalawa

ChangeLog.md

@@ -19,6 +19,7 @@
 - BUGFIX: #5342 Fixed broken filtering in View data, when the View's source table name requires quoting (i.e. has whitespaces, etc.).
 - BUGFIX: #5347 Fixed SQL formatter to keep single-quote wrapper around string literals.
 - BUGFIX: #5370 Fixed cell inline editor context menu actions for Copy, Cut and Delete.
+- BUGFIX: #5364 Fixed triggering inline cell editor with polish characters.
 - BUGFIX: Fixed arbitrary crashes when opening SQL Editor, while having non-thread-safe SQLite extensions loaded in the active database.
 
 ### 3.4.17

SQLiteStudio3/guiSQLiteStudio/datagrid/sqlqueryitemdelegate.cpp

@@ -47,6 +47,7 @@ void SqlQueryItemDelegate::paint(QPainter *painter, const QStyleOptionViewItem &
 
 QWidget* SqlQueryItemDelegate::createEditor(QWidget* parent, const QStyleOptionViewItem& option, const QModelIndex& index) const
 {
+    qDebug() << "create editor";
     UNUSED(option);
     if (!index.isValid())
         return nullptr;

SQLiteStudio3/guiSQLiteStudio/datagrid/sqlqueryview.cpp

@@ -47,7 +47,8 @@ void SqlQueryView::init()
     itemDelegate = new SqlQueryItemDelegate();
     setItemDelegate(itemDelegate);
     setMouseTracking(true);
-    setEditTriggers(QAbstractItemView::AnyKeyPressed|QAbstractItemView::EditKeyPressed);
+    // setEditTriggers(QAbstractItemView::AnyKeyPressed|QAbstractItemView::EditKeyPressed);
+    setEditTriggers(QAbstractItemView::NoEditTriggers);
 
     setContextMenuPolicy(Qt::CustomContextMenu);
     contextMenu = new QMenu(this);
@@ -668,6 +669,28 @@ void SqlQueryView::scrollContentsBy(int dx, int dy)
     emit scrolledBy(dx, dy);
 }
 
+void SqlQueryView::keyPressEvent(QKeyEvent *e)
+{
+    // Overriden EditTrigger, so it works consistently across platforms.
+    // Default implementation caused problem with Polish characters under Windows (#5364)
+    const QString txt = e->text();
+    bool shouldOpenEditor = false;
+    if (!txt.isEmpty() && txt.at(0).isPrint())
+    {
+        if (state() != QAbstractItemView::EditingState)
+            shouldOpenEditor = true;
+            // edit(currentIndex());
+    }
+
+    QTableView::keyPressEvent(e);
+
+    if (shouldOpenEditor)
+    {
+        edit(currentIndex());
+        QApplication::sendEvent(focusWidget(), e);
+    }
+}
+
 void SqlQueryView::updateCommitRollbackActions(bool enabled)
 {
     actionMap[COMMIT]->setEnabled(enabled);

SQLiteStudio3/guiSQLiteStudio/datagrid/sqlqueryview.h

@@ -93,6 +93,7 @@ class GUI_API_EXPORT SqlQueryView : public QTableView, public ExtActionContainer
 
     protected:
         void scrollContentsBy(int dx, int dy);
+        void keyPressEvent(QKeyEvent *e);
 
     private:
         class Header : public QHeaderView